From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Brett Creeley <brett.creeley@amd.com>,
alexanderduyck@fb.com, kuba@kernel.org, kernel-team@meta.com,
davem@davemloft.net, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: jdamato@fastly.com, stable@vger.kernel.org
Subject: Re: [PATCH net] fbnic: Set napi irq value after calling netif_napi_add
Date: Thu, 12 Sep 2024 23:16:55 +0100 [thread overview]
Message-ID: <26a35c93-5a59-4ca1-ba62-01258767b214@linux.dev> (raw)
In-Reply-To: <20240912174922.10550-1-brett.creeley@amd.com>
On 12/09/2024 18:49, Brett Creeley wrote:
> The driver calls netif_napi_set_irq() and then calls netif_napi_add(),
> which calls netif_napi_add_weight(). At the end of
> netif_napi_add_weight() is a call to netif_napi_set_irq(napi, -1), which
> clears the previously set napi->irq value. Fix this by calling
> netif_napi_set_irq() after calling netif_napi_add().
>
> This was found when reviewing another patch and I have no way to test
> this, but the fix seemed relatively straight forward.
> Cc: stable@vger.kernel.org
> Fixes: bc6107771bb4 ("eth: fbnic: Allocate a netdevice and napi vectors with queues")
> Signed-off-by: Brett Creeley <brett.creeley@amd.com>
I agree that irq vector is lost without this patch.
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
next prev parent reply other threads:[~2024-09-12 22:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 17:49 [PATCH net] fbnic: Set napi irq value after calling netif_napi_add Brett Creeley
2024-09-12 18:03 ` Joe Damato
2024-09-12 22:16 ` Vadim Fedorenko [this message]
2024-09-14 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26a35c93-5a59-4ca1-ba62-01258767b214@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=alexanderduyck@fb.com \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=jdamato@fastly.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox