* [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code
@ 2019-08-27 13:46 YueHaibing
2019-08-27 20:40 ` Ray Jui
2019-08-28 21:51 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-08-27 13:46 UTC (permalink / raw)
To: andrew, f.fainelli, hkallweit1, davem, rjui, sbranden
Cc: bcm-kernel-feedback-list, netdev, linux-arm-kernel, linux-kernel,
YueHaibing
Use devm_platform_ioremap_resource() to simplify the code a bit.
This is detected by coccinelle.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/phy/mdio-bcm-iproc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c
index 7d0f388..7e9975d 100644
--- a/drivers/net/phy/mdio-bcm-iproc.c
+++ b/drivers/net/phy/mdio-bcm-iproc.c
@@ -123,15 +123,13 @@ static int iproc_mdio_probe(struct platform_device *pdev)
{
struct iproc_mdio_priv *priv;
struct mii_bus *bus;
- struct resource *res;
int rc;
priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- priv->base = devm_ioremap_resource(&pdev->dev, res);
+ priv->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(priv->base)) {
dev_err(&pdev->dev, "failed to ioremap register\n");
return PTR_ERR(priv->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code
2019-08-27 13:46 [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code YueHaibing
@ 2019-08-27 20:40 ` Ray Jui
2019-08-28 21:51 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ray Jui @ 2019-08-27 20:40 UTC (permalink / raw)
To: YueHaibing, andrew, f.fainelli, hkallweit1, davem, rjui, sbranden
Cc: bcm-kernel-feedback-list, netdev, linux-arm-kernel, linux-kernel
On 2019-08-27 6:46 a.m., YueHaibing wrote:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/net/phy/mdio-bcm-iproc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-bcm-iproc.c b/drivers/net/phy/mdio-bcm-iproc.c
> index 7d0f388..7e9975d 100644
> --- a/drivers/net/phy/mdio-bcm-iproc.c
> +++ b/drivers/net/phy/mdio-bcm-iproc.c
> @@ -123,15 +123,13 @@ static int iproc_mdio_probe(struct platform_device *pdev)
> {
> struct iproc_mdio_priv *priv;
> struct mii_bus *bus;
> - struct resource *res;
> int rc;
>
> priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
> if (!priv)
> return -ENOMEM;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - priv->base = devm_ioremap_resource(&pdev->dev, res);
> + priv->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(priv->base)) {
> dev_err(&pdev->dev, "failed to ioremap register\n");
> return PTR_ERR(priv->base);
>
Looks good to me. Thanks.
Reviewed-by: Ray Jui <ray.jui@broadcom.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code
2019-08-27 13:46 [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-27 20:40 ` Ray Jui
@ 2019-08-28 21:51 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-08-28 21:51 UTC (permalink / raw)
To: yuehaibing
Cc: andrew, f.fainelli, hkallweit1, rjui, sbranden,
bcm-kernel-feedback-list, netdev, linux-arm-kernel, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Tue, 27 Aug 2019 21:46:16 +0800
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-28 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-27 13:46 [PATCH net-next] phy: mdio-bcm-iproc: use devm_platform_ioremap_resource() to simplify code YueHaibing
2019-08-27 20:40 ` Ray Jui
2019-08-28 21:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox