* re: sched: check negative err value to safe one level of indent
@ 2017-02-14 15:10 Colin Ian King
2017-02-14 15:20 ` Jiri Pirko
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2017-02-14 15:10 UTC (permalink / raw)
To: Jiri Pirko, Jamal Hadi Salim, David S. Miller,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Jiro,
A recent static analysis run with CoverityScan identified a potential
change in functionality with your recent commit "sched: check negative
err value to safe one level of indent" that landed in linux-next.
The original path for case RTM_DELTFILTER would always goto errout, but
your commit seems to goto errout only if err is non-zero zero and the
err == 0 path falls through to the RTM_GETTFILTER case. I'm not sure if
this is an intentional change in behaviour. From what I can make out,
there is a missing goto errout before the fall-through to RTM_GETTFILTER.
Colin
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sched: check negative err value to safe one level of indent
2017-02-14 15:10 sched: check negative err value to safe one level of indent Colin Ian King
@ 2017-02-14 15:20 ` Jiri Pirko
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Pirko @ 2017-02-14 15:20 UTC (permalink / raw)
To: Colin Ian King
Cc: Jiri Pirko, Jamal Hadi Salim, David S. Miller,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Tue, Feb 14, 2017 at 04:10:13PM CET, colin.king@canonical.com wrote:
>Jiro,
>
>A recent static analysis run with CoverityScan identified a potential
>change in functionality with your recent commit "sched: check negative
>err value to safe one level of indent" that landed in linux-next.
>
>The original path for case RTM_DELTFILTER would always goto errout, but
>your commit seems to goto errout only if err is non-zero zero and the
>err == 0 path falls through to the RTM_GETTFILTER case. I'm not sure if
>this is an intentional change in behaviour. From what I can make out,
>there is a missing goto errout before the fall-through to RTM_GETTFILTER.
Will fix. Thanks.
>
>Colin
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-14 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 15:10 sched: check negative err value to safe one level of indent Colin Ian King
2017-02-14 15:20 ` Jiri Pirko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox