From: yunchuan <yunchuan@nfschina.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: wg@grandegger.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, uttenthaler@ems-wuensche.com,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*) conversions
Date: Mon, 17 Jul 2023 15:04:49 +0800 [thread overview]
Message-ID: <29e3ea89-db2c-0b54-4af1-d8098f011a9e@nfschina.com> (raw)
In-Reply-To: <20230717-staple-uninjured-26bfd8cde5e0-mkl@pengutronix.de>
On 2023/7/17 14:52, Marc Kleine-Budde wrote:
> On 17.07.2023 11:12:21, Wu Yunchuan wrote:
>> No need cast (void*) to (struct ems_pci_card *).
>>
>> Signed-off-by: Wu Yunchuan <yunchuan@nfschina.com>
>> Acked-by: Marc Kleine-Budde<mkl@pengutronix.de>
> Please add a space between my name and my e-mail address, so that it
> reads:
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Hi,
Sorry for this, I will resend this patch to add a space.
>
> nitpick:
> You should add your S-o-b as the last trailer.
Oh, thanks for this reminder!
Wu Yunchuan
> regards,
> Marc
>
next prev parent reply other threads:[~2023-07-17 7:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 3:12 [PATCH net-next v3 8/9] can: ems_pci: Remove unnecessary (void*) conversions Wu Yunchuan
2023-07-17 6:52 ` Marc Kleine-Budde
2023-07-17 7:04 ` yunchuan [this message]
2023-07-17 7:07 ` Marc Kleine-Budde
2023-07-17 7:30 ` yunchuan
2023-07-17 7:33 ` Marc Kleine-Budde
2023-07-17 7:35 ` yunchuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29e3ea89-db2c-0b54-4af1-d8098f011a9e@nfschina.com \
--to=yunchuan@nfschina.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=uttenthaler@ems-wuensche.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox