Re: [RFC] net: remove NETIF_F_GSO_FRAGLIST from NETIF_F_GSO_SOFTWARE

[Felix Fietkau <nbd@nbd.name>]

On 16.08.24 16:13, Willem de Bruijn wrote:
> Felix Fietkau wrote:
>> Several drivers set NETIF_F_GSO_SOFTWARE, but mangle fraglist GRO packets
>> in a way that they can't be properly segmented anymore.
> 
> Can you share a bit more concrete detail: which driver, for instance, and
> how does it mangle the packet?
> 
> I assume something with inserting or deleting tunnel headers. But the
> fraglist skbs should be able to reproduce the modified header in
> skb_segment_list?

I've received bug reports from a variety of people, often with very 
little context, usually crashing while segmenting fraglist skbs.

The ones that people were able to easily reproduce involved bridging 
with vxlan or virtio net devices. People using those two reported that 
my patch fixed their crashes.

I will try to gather more information about the root cause of the crashes.

- Felix