Netdev List
 help / color / mirror / Atom feed
From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev@vger.kernel.org
Cc: Doug Berger <opendmb@gmail.com>,
	Nicolai Buchwitz <nb@tipi-net.de>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	open list <linux-kernel@vger.kernel.org>,
	Mlody12 mlody12 <kudzo51@gmail.com>
Subject: Re: [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac
Date: Tue, 17 Nov 2026 15:17:22 -0800	[thread overview]
Message-ID: <2c3c20ae-5866-463a-9bff-607c38b16a8f@broadcom.com> (raw)
In-Reply-To: <20261116213449.1682731-1-florian.fainelli@broadcom.com>

On 11/16/26 13:34, Florian Fainelli wrote:
> This patch series adds support for Clause 45 MDIO operations within the
> mdio-bcm-unimac driver. The series breaks things up in this way:
> 
> - make the C45 bus scan done by the MDIO core carry on when nothing
>    answers at an address, as the C22 scan already does
> - scope the existing defines to make it clear what is C22 vs. C45
>    specific
> - rework the polling completion loop to be a tighter loop
> - add support for clause 45 operations
> 
> Changes in v2:
> 
> - add patch 1, since providing read_c45/write_c45 makes the MDIO core scan
>    for C45 PHYs on all addresses that are not masked. On a bus registered
>    without a device tree node (e.g.: GENET with ACPI) a read from an empty
>    address fails with -EIO, which get_phy_c45_ids() passed up instead of
>    mapping it to -ENODEV, and made the whole bus registration fail. Reported
>    by Nicolai Buchwitz.
> - patches 2 and 3: collect Reviewed-by tags from Andrew Lunn and Nicolai
>    Buchwitz, no code changes
> - patch 4: no code changes
> 
> Florian Fainelli (4):
>    net: phy: Map C45 probe read errors to -ENODEV during bus scan
>    net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT
>    net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity
>    net: mdio: mdio-bcm-unimac: Add Clause 45 support
> 
>   drivers/net/mdio/mdio-bcm-unimac.c | 130 +++++++++++++++++++++++++----
>   drivers/net/phy/phy_device.c       |  24 ++++--
>   2 files changed, 134 insertions(+), 20 deletions(-)
> 

Sashiko pointed some valid issues commenting on v1, and has not reviewed 
v2 yet which does not incorporate all of the feedback. There will be a 
v3 submitted that incorporates the received feedback.

pw-bot: cr
-- 
Florian

      parent reply	other threads:[~2026-11-17 23:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 21:34 [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan Florian Fainelli
2026-11-17  9:33   ` Nicolai Buchwitz
2026-11-16 21:34 ` [PATCH net-next v2 2/4] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 3/4] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-17 12:36   ` Nicolai Buchwitz
2026-11-16 22:38 ` [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Kordian Chmielewski
2026-11-17 12:36 ` Nicolai Buchwitz
2026-11-17 23:17 ` Florian Fainelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c3c20ae-5866-463a-9bff-607c38b16a8f@broadcom.com \
    --to=florian.fainelli@broadcom.com \
    --cc=andrew@lunn.ch \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=kudzo51@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=nb@tipi-net.de \
    --cc=netdev@vger.kernel.org \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox