From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org
Cc: davem@davemloft.net, michaelsh86@gmail.com, ktkhai@virtuozzo.com,
sbrivio@redhat.com, sd@queasysnail.net, xiyou.wangcong@gmail.com,
dcaratti@redhat.com, weiyongjun1@huawei.com,
ivan.khoronzhuk@linaro.org, grygorii.strashko@ti.com,
tariqt@mellanox.com, makita.toshiaki@lab.ntt.co.jp,
mirq-linux@rere.qmqm.pl, mlxsw@mellanox.com
Subject: Re: [patch net-next] net: 8021q: move vlan offload registrations into vlan_core
Date: Wed, 14 Nov 2018 22:39:58 -0800 [thread overview]
Message-ID: <2ee1a172-9c70-61a9-8f8d-019db6f8e4d1@gmail.com> (raw)
In-Reply-To: <20181113222248.2773-1-jiri@resnulli.us>
On 11/13/18 2:22 PM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@mellanox.com>
>
> Currently, the vlan packet offloads are registered only upon 8021q module
> load. However, even without this module loaded, the offloads could be
> utilized, for example by openvswitch datapath. As reported by Michael,
> that causes 2x to 5x performance improvement, depending on a testcase.
>
> So move the vlan offload registrations into vlan_core and make this
> available even without 8021q module loaded.
>
> Reported-by: Michael Shteinbok <michaelsh86@gmail.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Tested-by: Michael Shteinbok <michaelsh86@gmail.com>
> ---
> net/8021q/vlan.c | 96 -----------------------------------------
> net/8021q/vlan_core.c | 99 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 99 insertions(+), 96 deletions(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2018-11-15 16:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 22:22 [patch net-next] net: 8021q: move vlan offload registrations into vlan_core Jiri Pirko
2018-11-15 6:39 ` David Ahern [this message]
2018-11-17 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ee1a172-9c70-61a9-8f8d-019db6f8e4d1@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=grygorii.strashko@ti.com \
--cc=ivan.khoronzhuk@linaro.org \
--cc=jiri@resnulli.us \
--cc=ktkhai@virtuozzo.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=michaelsh86@gmail.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=tariqt@mellanox.com \
--cc=weiyongjun1@huawei.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox