Netdev List
 help / color / mirror / Atom feed
From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Jakub Sitnicki <jakub@cloudflare.com>,
	netdev@vger.kernel.org, Florian Westphal <fw@strlen.de>,
	Paolo Abeni <pabeni@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski	 <kuba@kernel.org>,
	Simon Horman <horms@kernel.org>,
	Matt Johnston	 <matt@codeconstruct.com.au>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	 Herbert Xu <herbert@gondor.apana.org.au>,
	kernel-team@cloudflare.com
Subject: Re: [PATCH net-next 2/2] net: Make skb_ext_put_mctp() idempotent
Date: Tue, 01 Sep 2026 13:26:42 +0800	[thread overview]
Message-ID: <3393e21a6d0f17ebf3408ab63d5285408075974b.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260831-skb-ext-prep-work-v1-2-ecc2a8542fd9@cloudflare.com>

Hi Jakub,

> The MCTP flow extension can be released either when it is deleted from an
> skb or when the last skb holding the extension block is freed. Handle the
> release in __skb_ext_del(), which is currently missing, and make
> skb_ext_put_mctp() safe to call from both paths.

Looks good. We don't use the _del() path currently, but it also makes
sense to have the two forms consistent.

> This will let __skb_ext_put() release the MCTP key without checking whether
> the extension is present first, which is needed if we want to reuse skb_ext
> chunks area after skb scrubbing.

Acked-by: Jeremy Kerr <jk@codeconstruct.com.au>

Thanks!


Jeremy

  reply	other threads:[~2026-09-01  5:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31  6:27 [PATCH net-next 0/2] net: Prepare skb extensions for reuse across scrubs Jakub Sitnicki
2026-08-31  6:27 ` [PATCH net-next 1/2] net: Make skb_ext_put_sp() idempotent Jakub Sitnicki
2026-09-02  0:15   ` Jakub Kicinski
2026-09-02  5:51     ` Jakub Sitnicki
2026-09-02  9:24       ` Paolo Abeni
2026-09-02 14:03         ` Florian Westphal
2026-08-31  6:27 ` [PATCH net-next 2/2] net: Make skb_ext_put_mctp() idempotent Jakub Sitnicki
2026-09-01  5:26   ` Jeremy Kerr [this message]
2026-09-02  0:36 ` [PATCH net-next 0/2] net: Prepare skb extensions for reuse across scrubs patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3393e21a6d0f17ebf3408ab63d5285408075974b.camel@codeconstruct.com.au \
    --to=jk@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fw@strlen.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=horms@kernel.org \
    --cc=jakub@cloudflare.com \
    --cc=kernel-team@cloudflare.com \
    --cc=kuba@kernel.org \
    --cc=matt@codeconstruct.com.au \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox