* [PATCH v2 0/2] net: pcs: rzn1-miic: Fix config array initialization
@ 2026-09-01 15:25 Kyle Hendry via B4 Relay
2026-09-01 15:25 ` [PATCH v2 1/2] " Kyle Hendry via B4 Relay
2026-09-01 15:25 ` [PATCH v2 2/2] net: pcs: rzn1-miic: Verify port number from dtb Kyle Hendry via B4 Relay
0 siblings, 2 replies; 6+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-09-01 15:25 UTC (permalink / raw)
To: Clément Léger, Andrew Lunn, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: linux-renesas-soc, netdev, linux-kernel, Kyle Hendry
Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
Fix issues when populating dt_val array from device tree values
Changes in v2:
* Use a more correct array size in memset
* Ensure that write to dt_val is in range
Link to v1: https://lore.kernel.org/r/20260813-rzn1-miic-fix-array-v1-1-b58cafcc917e@reliablecontrols.com
---
Kyle Hendry (2):
net: pcs: rzn1-miic: Fix config array initialization
net: pcs: rzn1-miic: Verify port number from dtb
drivers/net/pcs/pcs-rzn1-miic.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
---
base-commit: 1376afc7660bad2a1a5ee0876898312a486cf8bd
change-id: 20260813-rzn1-miic-fix-array-e6ae4452c017
Best regards,
--
Kyle Hendry <khendry@reliablecontrols.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/2] net: pcs: rzn1-miic: Fix config array initialization
2026-09-01 15:25 [PATCH v2 0/2] net: pcs: rzn1-miic: Fix config array initialization Kyle Hendry via B4 Relay
@ 2026-09-01 15:25 ` Kyle Hendry via B4 Relay
2026-09-01 16:02 ` Andrew Lunn
2026-09-02 7:05 ` Geert Uytterhoeven
2026-09-01 15:25 ` [PATCH v2 2/2] net: pcs: rzn1-miic: Verify port number from dtb Kyle Hendry via B4 Relay
1 sibling, 2 replies; 6+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-09-01 15:25 UTC (permalink / raw)
To: Clément Léger, Andrew Lunn, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: linux-renesas-soc, netdev, linux-kernel, Kyle Hendry
From: Kyle Hendry <khendry@reliablecontrols.com>
Fix memset parameters to initialize the entire DT value array
Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
drivers/net/pcs/pcs-rzn1-miic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index 2b72fa98ddf1..c50b65d064fa 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -683,7 +683,7 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
if (!dt_val)
return -ENOMEM;
- memset(dt_val, MIIC_MODCTRL_CONF_NONE, sizeof(*dt_val));
+ memset(dt_val, MIIC_MODCTRL_CONF_NONE, sizeof(*dt_val) * miic->of_data->conf_conv_count);
if (of_property_read_u32(np, "renesas,miic-switch-portin", &conf) == 0)
dt_val[0] = conf;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/2] net: pcs: rzn1-miic: Verify port number from dtb
2026-09-01 15:25 [PATCH v2 0/2] net: pcs: rzn1-miic: Fix config array initialization Kyle Hendry via B4 Relay
2026-09-01 15:25 ` [PATCH v2 1/2] " Kyle Hendry via B4 Relay
@ 2026-09-01 15:25 ` Kyle Hendry via B4 Relay
2026-09-01 16:02 ` Andrew Lunn
1 sibling, 1 reply; 6+ messages in thread
From: Kyle Hendry via B4 Relay @ 2026-09-01 15:25 UTC (permalink / raw)
To: Clément Léger, Andrew Lunn, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni
Cc: linux-renesas-soc, netdev, linux-kernel, Kyle Hendry
From: Kyle Hendry <khendry@reliablecontrols.com>
Add check to make sure port number is in range before writing
to dt_val array
Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
---
drivers/net/pcs/pcs-rzn1-miic.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
index c50b65d064fa..ebd73ed63896 100644
--- a/drivers/net/pcs/pcs-rzn1-miic.c
+++ b/drivers/net/pcs/pcs-rzn1-miic.c
@@ -692,6 +692,11 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
if (of_property_read_u32(conv, "reg", &port))
continue;
+ if (port < miic->of_data->miic_port_start || port > miic->of_data->miic_port_max) {
+ dev_err(miic->dev, "Port number out of range: %d\n", port);
+ continue;
+ }
+
if (of_property_read_u32(conv, "renesas,miic-input", &conf))
continue;
--
2.43.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/2] net: pcs: rzn1-miic: Verify port number from dtb
2026-09-01 15:25 ` [PATCH v2 2/2] net: pcs: rzn1-miic: Verify port number from dtb Kyle Hendry via B4 Relay
@ 2026-09-01 16:02 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2026-09-01 16:02 UTC (permalink / raw)
To: khendry
Cc: Clément Léger, Heiner Kallweit, Russell King,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-renesas-soc, netdev, linux-kernel
On Tue, Sep 01, 2026 at 08:25:14AM -0700, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
>
> Add check to make sure port number is in range before writing
> to dt_val array
>
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
> ---
> drivers/net/pcs/pcs-rzn1-miic.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c
> index c50b65d064fa..ebd73ed63896 100644
> --- a/drivers/net/pcs/pcs-rzn1-miic.c
> +++ b/drivers/net/pcs/pcs-rzn1-miic.c
> @@ -692,6 +692,11 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
> if (of_property_read_u32(conv, "reg", &port))
> continue;
>
> + if (port < miic->of_data->miic_port_start || port > miic->of_data->miic_port_max) {
> + dev_err(miic->dev, "Port number out of range: %d\n", port);
> + continue;
Better to return -EINVAL, so the probe fails and the broken DT blob is
fixed.
Andrew
---
pw-bot: cr
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] net: pcs: rzn1-miic: Fix config array initialization
2026-09-01 15:25 ` [PATCH v2 1/2] " Kyle Hendry via B4 Relay
@ 2026-09-01 16:02 ` Andrew Lunn
2026-09-02 7:05 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2026-09-01 16:02 UTC (permalink / raw)
To: khendry
Cc: Clément Léger, Heiner Kallweit, Russell King,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-renesas-soc, netdev, linux-kernel
On Tue, Sep 01, 2026 at 08:25:13AM -0700, Kyle Hendry via B4 Relay wrote:
> From: Kyle Hendry <khendry@reliablecontrols.com>
>
> Fix memset parameters to initialize the entire DT value array
>
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 1/2] net: pcs: rzn1-miic: Fix config array initialization
2026-09-01 15:25 ` [PATCH v2 1/2] " Kyle Hendry via B4 Relay
2026-09-01 16:02 ` Andrew Lunn
@ 2026-09-02 7:05 ` Geert Uytterhoeven
1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2026-09-02 7:05 UTC (permalink / raw)
To: khendry
Cc: Clément Léger, Andrew Lunn, Heiner Kallweit,
Russell King, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-renesas-soc, netdev, linux-kernel,
Lad, Prabhakar
Hi Kyle,
CC Prabhakar
On Tue, 1 Sept 2026 at 17:53, Kyle Hendry via B4 Relay
<devnull+khendry.reliablecontrols.com@kernel.org> wrote:
>
> From: Kyle Hendry <khendry@reliablecontrols.com>
>
> Fix memset parameters to initialize the entire DT value array
>
> Signed-off-by: Kyle Hendry <khendry@reliablecontrols.com>
Thanks for your patch!
You forgot to add
Fixes: f39e968dc168a7bd ("net: pcs: rzn1-miic: Move configuration data
to SoC-specific struct")
as requested in my review of v1.
> --- a/drivers/net/pcs/pcs-rzn1-miic.c
> +++ b/drivers/net/pcs/pcs-rzn1-miic.c
> @@ -683,7 +683,7 @@ static int miic_parse_dt(struct miic *miic, u32 *mode_cfg)
> if (!dt_val)
> return -ENOMEM;
>
> - memset(dt_val, MIIC_MODCTRL_CONF_NONE, sizeof(*dt_val));
> + memset(dt_val, MIIC_MODCTRL_CONF_NONE, sizeof(*dt_val) * miic->of_data->conf_conv_count);
>
> if (of_property_read_u32(np, "renesas,miic-switch-portin", &conf) == 0)
> dt_val[0] = conf;
>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-09-02 7:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-01 15:25 [PATCH v2 0/2] net: pcs: rzn1-miic: Fix config array initialization Kyle Hendry via B4 Relay
2026-09-01 15:25 ` [PATCH v2 1/2] " Kyle Hendry via B4 Relay
2026-09-01 16:02 ` Andrew Lunn
2026-09-02 7:05 ` Geert Uytterhoeven
2026-09-01 15:25 ` [PATCH v2 2/2] net: pcs: rzn1-miic: Verify port number from dtb Kyle Hendry via B4 Relay
2026-09-01 16:02 ` Andrew Lunn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox