From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: ethernet: ave: Remove unnecessary 'out of memory' message
Date: Fri, 9 Jan 2026 09:27:03 +0900 [thread overview]
Message-ID: <34aaa094-daff-4045-b830-1687488c3e8e@socionext.com> (raw)
In-Reply-To: <81841486-b0c2-4f12-b4d5-08fe214f18d9@lunn.ch>
Hi Andrew,
On 2026/01/09 3:32, Andrew Lunn wrote:
> On Thu, Jan 08, 2026 at 03:46:40PM +0900, Kunihiko Hayashi wrote:
>> Follow the warning from checkpatch.pl and remove 'out of memory'
> message.
>>
>> WARNING: Possible unnecessary 'out of memory' message
>> #590: FILE: drivers/net/ethernet/socionext/sni_ave.c:590:
>> + if (!skb) {
>> + netdev_err(ndev, "can't allocate skb for
> Rx\n");
>
> Please take a read of
>
> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>
> You tagged this for net, not net-next. I would say this is not a fix.
Thank you for pointing out.
I thought this was a "fix" for the warning, however, it's not a logical
fix. So I'll repost it as net-next.
Thank you,
---
Best Regards
Kunihiko Hayashi
next prev parent reply other threads:[~2026-01-09 0:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 6:46 [PATCH net 1/2] net: ethernet: ave: Remove unnecessary 'out of memory' message Kunihiko Hayashi
2026-01-08 6:46 ` [PATCH net 2/2] net: ethernet: ave: Replace udelay with usleep_range Kunihiko Hayashi
2026-01-08 9:05 ` David Laight
2026-01-09 0:59 ` Kunihiko Hayashi
2026-01-08 18:32 ` [PATCH net 1/2] net: ethernet: ave: Remove unnecessary 'out of memory' message Andrew Lunn
2026-01-09 0:27 ` Kunihiko Hayashi [this message]
2026-01-09 1:20 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34aaa094-daff-4045-b830-1687488c3e8e@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox