From: Andrew Lunn <andrew@lunn.ch>
To: "Smith, Cameron T" <cameron.smith@pnnl.gov>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"horms@kernel.org" <horms@kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"boqun@kernel.org" <boqun@kernel.org>,
"gary@garyguo.net" <gary@garyguo.net>,
"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
"lossin@kernel.org" <lossin@kernel.org>,
"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"tmgross@umich.edu" <tmgross@umich.edu>,
"dakr@kernel.org" <dakr@kernel.org>,
"daniel.almeida@collabora.com" <daniel.almeida@collabora.com>,
"tamird@kernel.org" <tamird@kernel.org>,
"acourbot@nvidia.com" <acourbot@nvidia.com>,
"work@onurozkan.dev" <work@onurozkan.dev>,
Sabrina Dubroca <sd@queasysnail.net>,
"Griswold, Richard L" <richard.griswold@pnnl.gov>,
"Phillips, Aaron R" <Aaron.Phillips@pnnl.gov>
Subject: Re: MAC Privacy Protection Protocol Driver Announcement
Date: Tue, 27 Oct 2026 14:15:50 +0100 [thread overview]
Message-ID: <364891b2-88ee-45d0-899a-cb2e919eae6c@lunn.ch> (raw)
In-Reply-To: <8D2A251F-C6BB-49AE-84DB-459FD7532306@pnnl.gov>
On Mon, Oct 26, 2026 at 10:54:34PM +0000, Smith, Cameron T wrote:
> On Fri, Oct 23, 2026 at 03:00:23AM +0200 Andrew Lunn wrote:
> > So if you use it without MACSEC, you preappend a new header, and send
> > it out. Isn't the inner header than in plain text, making it somewhat
> > pointless?
>
> Yes. In practice if MAC Privacy data is not encrypted, the changes
> it's made to traffic can be trivially observed and reversed. However,
> the standard doesn't require encryption or mandate how encryption
> should take place.
What happens in practice? Just because the standard allows you to do
something does not mean we actually need to support it, especially if
it gives a sense of privacy when in fact it does not.
From an architecture perspective, i'm wondering if it should be a thin
sublayer in drivers/net/macsec.c. That then forces you to use it in
the correct way, it does actually give you privacy.
> This flexibility allows the use case where mac
> privacy encryption takes place on another device, such as an
> Ethernet Data Encryptor. (See 802.1AEdk-2023 Section 21.8)
Does linux support this? And since this is 802.1AE, i assume it is an
extension to MACSEC? So would it be implemented in
drivers/net/macsec.c ?
> > For the timing part, how does this interact with TSN, sk_buff->tstamp
> > TAPRIO and ETF Qdisc? Clearly you want to reuse as much of that as
> > possible.
>
> I definitely want to reuse as much as possible. MAC Privacy can use
> VLAN tags to indicate priority (See 802.1AEdk-2023 Figure 17-2), but
> I will need to look more closely at this topic.
I suspect this work will split into two parts. You will need TC and
some form of Qdisc, maybe extensions to the existing one, or maybe a
new one. And you need a layer somewhere to do the packet manipulation.
> Adding a MAC Privacy link to an existing Ethernet link named eth0
> without macsec might look like this:
>
> ip link add link eth0 name macpriv0 type macpriv
>
> Adding a MAC Privacy link to an existing macsec link named macsec0
> might look like this:
>
> ip link add link macsec0 name macpriv0 type macpriv
As you can see above, i'm not yet convinced it should be a new device
stacked on top of macsec. Please explore what it would mean if the
packet manipulation part was inside the existing macsec driver. And
the packet scheduling is done via a Qdisc.
Andrew
next prev parent reply other threads:[~2026-10-27 13:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PH0PR09MB114568347F3E0622F9102AF628A662@PH0PR09MB11456.namprd09.prod.outlook.com>
2026-10-21 19:10 ` MAC Privacy Protection Protocol Driver Announcement Andrew Lunn
2026-10-22 22:55 ` Smith, Cameron T
2026-10-23 1:00 ` Andrew Lunn
2026-10-26 22:54 ` Smith, Cameron T
2026-10-27 13:15 ` Andrew Lunn [this message]
2026-10-22 21:11 Smith, Cameron T
2026-10-23 19:38 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364891b2-88ee-45d0-899a-cb2e919eae6c@lunn.ch \
--to=andrew@lunn.ch \
--cc=Aaron.Phillips@pnnl.gov \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=aliceryhl@google.com \
--cc=andrew+netdev@lunn.ch \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun@kernel.org \
--cc=cameron.smith@pnnl.gov \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gary@garyguo.net \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=lossin@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=pabeni@redhat.com \
--cc=richard.griswold@pnnl.gov \
--cc=sd@queasysnail.net \
--cc=tamird@kernel.org \
--cc=tmgross@umich.edu \
--cc=work@onurozkan.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox