Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Smith, Cameron T" <cameron.smith@pnnl.gov>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"kuba@kernel.org" <kuba@kernel.org>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"horms@kernel.org" <horms@kernel.org>,
	"ojeda@kernel.org" <ojeda@kernel.org>,
	"boqun@kernel.org" <boqun@kernel.org>,
	"gary@garyguo.net" <gary@garyguo.net>,
	"bjorn3_gh@protonmail.com" <bjorn3_gh@protonmail.com>,
	"lossin@kernel.org" <lossin@kernel.org>,
	"a.hindborg@kernel.org" <a.hindborg@kernel.org>,
	"aliceryhl@google.com" <aliceryhl@google.com>,
	"tmgross@umich.edu" <tmgross@umich.edu>,
	"dakr@kernel.org" <dakr@kernel.org>,
	"daniel.almeida@collabora.com" <daniel.almeida@collabora.com>,
	"tamird@kernel.org" <tamird@kernel.org>,
	"acourbot@nvidia.com" <acourbot@nvidia.com>,
	"work@onurozkan.dev" <work@onurozkan.dev>,
	Sabrina Dubroca <sd@queasysnail.net>,
	"Griswold, Richard L" <richard.griswold@pnnl.gov>,
	"Phillips, Aaron R" <Aaron.Phillips@pnnl.gov>
Subject: Re: MAC Privacy Protection Protocol Driver Announcement
Date: Fri, 23 Oct 2026 03:00:23 +0200	[thread overview]
Message-ID: <8546582a-e5be-471f-87e5-5eb68433083f@lunn.ch> (raw)
In-Reply-To: <B0D3346C-ACAD-4938-8B3A-501F9CD52C64@pnnl.gov>

On Thu, Oct 22, 2026 at 10:55:59PM +0000, Smith, Cameron T wrote:
> Hi Andrew,
> 
> Thanks for the recommendation to include Sabrina Dubroca.
> 
> On 10/21/26, 12:10, "Andrew Lunn" <andrew@lunn.ch <mailto:andrew@lunn.ch>> wrote:
> > So this is part of macsec?
> 
> Yes and no. It's standardized by IEEE as an amendment to 802.1AE and 
> intended for use with MACsec. However, it's defined as a separate protocol 
> with a dedicated ethertype, and the specification allows it to be used 
> without MACsec. 

I spent maybe 10 minutes looking at standard, so i've not got a good
understanding of it, so maybe i'm asking dumb questions.

So if you use it without MACSEC, you preappend a new header, and send
it out. Isn't the inner header than in plain text, making it somewhat
pointless?

> > Lets start with architecture. How does this interactive with macsec?
> > Is it a layer on top? Is it integrated into the existing macsec
> > driver? Is it layered below? Are there devices which support 802.1AEdk
> > in hardware? There are PHYs which can do macsec and there is an API to
> > perform this offload. Do we need to extend this API?
> 
> When used with MACsec, each MAC Privacy protection Protocol Data Unit
> (MPPDU) is placed within the payload of a MACsec data unit. Also, as 
> mentioned above, use of MACsec is not required, and one could use another 
> protocol, such as Ethernet, instead. Because of this, I think it makes 
> sense to implement MAC Privacy as a separate driver from MACsec. 

For the timing part, how does this interact with TSN, sk_buff->tstamp
TAPRIO and ETF Qdisc? Clearly you want to reuse as much of that as
possible.

> To my knowledge there are not currently any devices which support 802.1AEdk
> in hardware. Implementing MAC Privacy as a separate driver means
> hardware offload for MACsec can be used without changes while allowing
> Linux to perform MAC Privacy.

But we need a path for when MAC privacy is in hardware. However, is
that actually possible? The encapsulation to hide the MAC addresses
and perform padding should be possible, but what about the timing
part? Can that be offloaded? I guess not in a PHY, but a MAC
implementation would be possible, it pulling packets out of a queue at
a given rate, adding the extra header and padding, and then putting it
on the wire.

What does you user configuration API look like? Can you give us
examples of what you think iproute2 would look like, both with it
stacked on macsec, and directly on top of Ethernet. And what tc
commands are required.

   Andrew




  reply	other threads:[~2026-10-23  1:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <PH0PR09MB114568347F3E0622F9102AF628A662@PH0PR09MB11456.namprd09.prod.outlook.com>
2026-10-21 19:10 ` MAC Privacy Protection Protocol Driver Announcement Andrew Lunn
2026-10-22 22:55   ` Smith, Cameron T
2026-10-23  1:00     ` Andrew Lunn [this message]
2026-10-26 22:54       ` Smith, Cameron T
2026-10-27 13:15         ` Andrew Lunn
2026-10-22 21:11 Smith, Cameron T
2026-10-23 19:38 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8546582a-e5be-471f-87e5-5eb68433083f@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Aaron.Phillips@pnnl.gov \
    --cc=a.hindborg@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=aliceryhl@google.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun@kernel.org \
    --cc=cameron.smith@pnnl.gov \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gary@garyguo.net \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lossin@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ojeda@kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richard.griswold@pnnl.gov \
    --cc=sd@queasysnail.net \
    --cc=tamird@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=work@onurozkan.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox