From: Jan Janssen <medhefgo@web.de>
To: dsahern@gmail.com
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Regression: youtube-dl hanging on download
Date: Sat, 25 Aug 2018 17:23:38 +0200 [thread overview]
Message-ID: <36553198.DNrMIUSMyK@minako> (raw)
Hi,
youtube-dl hangs trying to download videos from youtube. The commit below is
my regression test result. Disabling ipv6 indeed does fix this for me.
Jan
---
d4ead6b34b67fd711639324b6465a050bcb197d4 is the first bad commit
commit d4ead6b34b67fd711639324b6465a050bcb197d4
Author: David Ahern <dsahern@gmail.com>
Date: Tue Apr 17 17:33:16 2018 -0700
net/ipv6: move metrics from dst to rt6_info
Similar to IPv4, add fib metrics to the fib struct, which at the moment
is rt6_info. Will be moved to fib6_info in a later patch. Copy metrics
into dst by reference using refcount.
To make the transition:
- add dst_metrics to rt6_info. Default to dst_default_metrics if no
metrics are passed during route add. No need for a separate pmtu
entry; it can reference the MTU slot in fib6_metrics
- ip6_convert_metrics allocates memory in the FIB entry and uses
ip_metrics_convert to copy from netlink attribute to metrics entry
- the convert metrics call is done in ip6_route_info_create simplifying
the route add path
+ fib6_commit_metrics and fib6_copy_metrics and the temporary
mx6_config are no longer needed
- add fib6_metric_set helper to change the value of a metric in the
fib entry since dst_metric_set can no longer be used
- cow_metrics for IPv6 can drop to dst_cow_metrics_generic
- rt6_dst_from_metrics_check is no longer needed
- rt6_fill_node needs the FIB entry and dst as separate arguments to
keep compatibility with existing output. Current dst address is
renamed to dest.
(to be consistent with IPv4 rt6_fill_node really should be split
into 2 functions similar to fib_dump_info and rt_fill_info)
- rt6_fill_node no longer needs the temporary metrics variable
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
:040000 040000 1256a75be6bb5b9f3ef5b38ff75cfd10aba1a856
d6cc99cbefe99bb3a5c1b73b6dcccd8ec0816ec5 M include
:040000 040000 36a3fa59bea55e68c88a4fe2d1ac653fa8a50705
cdbd8a8aa4d8bc2e8abf6bdf18b30388a957183c M net
next reply other threads:[~2018-08-25 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 15:23 Jan Janssen [this message]
2018-08-25 15:47 ` Regression: youtube-dl hanging on download David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36553198.DNrMIUSMyK@minako \
--to=medhefgo@web.de \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox