* Regression: youtube-dl hanging on download
@ 2018-08-25 15:23 Jan Janssen
2018-08-25 15:47 ` David Ahern
0 siblings, 1 reply; 2+ messages in thread
From: Jan Janssen @ 2018-08-25 15:23 UTC (permalink / raw)
To: dsahern; +Cc: davem, kuznet, yoshfuji, netdev
Hi,
youtube-dl hangs trying to download videos from youtube. The commit below is
my regression test result. Disabling ipv6 indeed does fix this for me.
Jan
---
d4ead6b34b67fd711639324b6465a050bcb197d4 is the first bad commit
commit d4ead6b34b67fd711639324b6465a050bcb197d4
Author: David Ahern <dsahern@gmail.com>
Date: Tue Apr 17 17:33:16 2018 -0700
net/ipv6: move metrics from dst to rt6_info
Similar to IPv4, add fib metrics to the fib struct, which at the moment
is rt6_info. Will be moved to fib6_info in a later patch. Copy metrics
into dst by reference using refcount.
To make the transition:
- add dst_metrics to rt6_info. Default to dst_default_metrics if no
metrics are passed during route add. No need for a separate pmtu
entry; it can reference the MTU slot in fib6_metrics
- ip6_convert_metrics allocates memory in the FIB entry and uses
ip_metrics_convert to copy from netlink attribute to metrics entry
- the convert metrics call is done in ip6_route_info_create simplifying
the route add path
+ fib6_commit_metrics and fib6_copy_metrics and the temporary
mx6_config are no longer needed
- add fib6_metric_set helper to change the value of a metric in the
fib entry since dst_metric_set can no longer be used
- cow_metrics for IPv6 can drop to dst_cow_metrics_generic
- rt6_dst_from_metrics_check is no longer needed
- rt6_fill_node needs the FIB entry and dst as separate arguments to
keep compatibility with existing output. Current dst address is
renamed to dest.
(to be consistent with IPv4 rt6_fill_node really should be split
into 2 functions similar to fib_dump_info and rt_fill_info)
- rt6_fill_node no longer needs the temporary metrics variable
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
:040000 040000 1256a75be6bb5b9f3ef5b38ff75cfd10aba1a856
d6cc99cbefe99bb3a5c1b73b6dcccd8ec0816ec5 M include
:040000 040000 36a3fa59bea55e68c88a4fe2d1ac653fa8a50705
cdbd8a8aa4d8bc2e8abf6bdf18b30388a957183c M net
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Regression: youtube-dl hanging on download
2018-08-25 15:23 Regression: youtube-dl hanging on download Jan Janssen
@ 2018-08-25 15:47 ` David Ahern
0 siblings, 0 replies; 2+ messages in thread
From: David Ahern @ 2018-08-25 15:47 UTC (permalink / raw)
To: Jan Janssen; +Cc: davem, kuznet, yoshfuji, netdev
On 8/25/18 9:23 AM, Jan Janssen wrote:
> Hi,
>
> youtube-dl hangs trying to download videos from youtube. The commit below is
> my regression test result. Disabling ipv6 indeed does fix this for me.
>
Thanks for the report. Can you boot a pre-4.18 kernel and send me,
offlist, the output of 'ip -6 ro ls table all'?
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-25 19:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-25 15:23 Regression: youtube-dl hanging on download Jan Janssen
2018-08-25 15:47 ` David Ahern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox