public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: John Fastabend <john.fastabend@gmail.com>,
	ast@kernel.org, davejwatson@fb.com
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [bpf PATCH 0/2] tls, sockmap, fixes for sk_wait_event
Date: Wed, 22 Aug 2018 23:52:15 +0200	[thread overview]
Message-ID: <3676efa3-e8ea-1748-a661-0d58cc943833@iogearbox.net> (raw)
In-Reply-To: <20180822153314.27968.72499.stgit@john-Precision-Tower-5810>

On 08/22/2018 05:37 PM, John Fastabend wrote:
> I have been testing ktls and sockmap lately and noticed that neither
> was handling sk_write_space events correctly. We need to ensure
> these events are pushed down to the lower layer in all cases to
> handle the case where the lower layer sendpage call has called
> sk_wait_event and needs to be woken up. Without this I see
> occosional stalls of sndtimeo length while we wait for the
> timeout value even though space is available.
> 
> Two fixes below. Thanks.
> 
> ---
> 
> John Fastabend (2):
>       tls: possible hang when do_tcp_sendpages hits sndbuf is full case
>       bpf: sockmap: write_space events need to be passed to TCP handler
> 
> 
>  kernel/bpf/sockmap.c |    3 +++
>  net/tls/tls_main.c   |    9 +++++++--
>  2 files changed, 10 insertions(+), 2 deletions(-)

Applied to bpf, thanks John!

      parent reply	other threads:[~2018-08-23  1:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22 15:37 [bpf PATCH 0/2] tls, sockmap, fixes for sk_wait_event John Fastabend
2018-08-22 15:37 ` [bpf PATCH 1/2] tls: possible hang when do_tcp_sendpages hits sndbuf is full case John Fastabend
2018-08-22 18:22   ` Dave Watson
2018-08-22 15:37 ` [bpf PATCH 2/2] bpf: sockmap: write_space events need to be passed to TCP handler John Fastabend
2018-08-22 18:40 ` [bpf PATCH 0/2] tls, sockmap, fixes for sk_wait_event Alexei Starovoitov
2018-08-22 21:52 ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3676efa3-e8ea-1748-a661-0d58cc943833@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=ast@kernel.org \
    --cc=davejwatson@fb.com \
    --cc=davem@davemloft.net \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox