From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Mauricio Vasquez <mauricio.vasquez@polito.it>
Cc: Alexei Starovoitov <ast@kernel.org>, netdev@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: hash_map: decrement counter on error
Date: Tue, 3 Jul 2018 23:28:18 +0200 [thread overview]
Message-ID: <39431a52-0da4-d15f-6bbb-664b80bbc683@iogearbox.net> (raw)
In-Reply-To: <20180703202849.dydvuwcc6bcvy57i@ast-mbp.dhcp.thefacebook.com>
On 07/03/2018 10:28 PM, Alexei Starovoitov wrote:
> On Sun, Jul 01, 2018 at 11:33:58AM -0500, Mauricio Vasquez wrote:
>> On 06/30/2018 06:20 PM, Daniel Borkmann wrote:
>>> On 06/29/2018 02:48 PM, Mauricio Vasquez B wrote:
>>>> Decrement the number of elements in the map in case the allocation
>>>> of a new node fails.
>>>>
>>>> Signed-off-by: Mauricio Vasquez B <mauricio.vasquez@polito.it>
>>> Thanks for the fix, Mauricio!
>>>
>>> Could you reply with a Fixes: tag in order to track the commit originally
>>> introducing this bug?
>>
>> Sure Daniel,
>>
>> Fixes: 6c9059817432 ("bpf: pre-allocate hash map elements")
>
> Good catch. Thanks for the fix.
> Acked-by: Alexei Starovoitov <ast@kernel.org>
Applied to bpf, thanks Mauricio!
prev parent reply other threads:[~2018-07-03 21:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 12:48 [PATCH bpf] bpf: hash_map: decrement counter on error Mauricio Vasquez B
2018-06-30 23:20 ` Daniel Borkmann
2018-07-01 16:33 ` Mauricio Vasquez
2018-07-03 20:28 ` Alexei Starovoitov
2018-07-03 21:28 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39431a52-0da4-d15f-6bbb-664b80bbc683@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=mauricio.vasquez@polito.it \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox