public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Victor Nogueira <victor@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: jhs@mojatatu.com, jiri@resnulli.us, edumazet@google.com,
	gerrard.tai@starlabs.sg, Pedro Tammela <pctammela@mojatatu.com>
Subject: Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL with HTB parent
Date: Sun, 23 Mar 2025 19:48:39 -0300	[thread overview]
Message-ID: <3a60ae0c-0b5f-44e9-8063-29d0d290699c@mojatatu.com> (raw)
In-Reply-To: <20250320232539.486091-8-xiyou.wangcong@gmail.com>

On 20/03/2025 20:25, Cong Wang wrote:
> Add a test case for CODEL with HTB parent to verify packet drop
> behavior when the queue becomes empty. This helps ensure proper
> notification mechanisms between qdiscs.
> 
> Note this is best-effort, it is hard to play with those parameters
> perfectly to always trigger ->qlen_notify().
> 
> Cc: Pedro Tammela <pctammela@mojatatu.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>

Cong, can you double check this test?
I ran all of your other tests and they all succeeded, however
this one specifically is always failing:

Test a4bd: Test CODEL with HTB parent - force packet drop with empty queue

All test results:

1..1
not ok 1 a4bd - Test CODEL with HTB parent - force packet drop with 
empty queue
         Could not match regex pattern. Verify command output:
qdisc codel 10: parent 1:10 limit 1p target 9us interval 999us
  Sent 2884 bytes 2 pkt (dropped 0, overlimits 0 requeues 0)
  backlog 0b 0p requeues 0
   count 0 lastcount 0 ldelay 11.5s drop_next 0us
   maxpacket 1442 ecn_mark 0 drop_overlimit 0

cheers,
Victor

  reply	other threads:[~2025-03-23 22:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-20 23:21 [Patch net 00/12] net_sched: make ->qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 01/12] sch_htb: make htb_qlen_notify() idempotent Cong Wang
2025-03-20 23:25   ` [Patch net 02/12] sch_drr: make drr_qlen_notify() idempotent Cong Wang
2025-03-20 23:25   ` [Patch net 03/12] sch_hfsc: make hfsc_qlen_notify() idempotent Cong Wang
2025-03-20 23:25   ` [Patch net 04/12] sch_qfq: make qfq_qlen_notify() idempotent Cong Wang
2025-03-20 23:25   ` [Patch net 05/12] sch_ets: make est_qlen_notify() idempotent Cong Wang
2025-03-20 23:25   ` [Patch net 06/12] codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog() Cong Wang
2025-03-20 23:25   ` [Patch net 07/12] selftests/tc-testing: Add a test case for FQ_CODEL with HTB parent Cong Wang
2025-03-20 23:25   ` [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL " Cong Wang
2025-03-23 22:48     ` Victor Nogueira [this message]
2025-03-28 20:35       ` Cong Wang
2025-03-30 21:05         ` Victor Nogueira
2025-03-30 23:32           ` Cong Wang
2025-04-03  0:40             ` Cong Wang
2025-04-03  1:23               ` Victor Nogueira
2025-04-03 19:32                 ` Cong Wang
2025-03-20 23:25   ` [Patch net 09/12] selftests/tc-testing: Add a test case for FQ_CODEL with QFQ parent Cong Wang
2025-03-20 23:25   ` [Patch net 10/12] selftests/tc-testing: Add a test case for FQ_CODEL with HFSC parent Cong Wang
2025-03-20 23:25   ` [Patch net 11/12] selftests/tc-testing: Add a test case for FQ_CODEL with DRR parent Cong Wang
2025-03-20 23:25   ` [Patch net 12/12] selftests/tc-testing: Add a test case for FQ_CODEL with ETS parent Cong Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a60ae0c-0b5f-44e9-8063-29d0d290699c@mojatatu.com \
    --to=victor@mojatatu.com \
    --cc=edumazet@google.com \
    --cc=gerrard.tai@starlabs.sg \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=pctammela@mojatatu.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox