From: Victor Nogueira <victor@mojatatu.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: netdev@vger.kernel.org, jhs@mojatatu.com, jiri@resnulli.us,
edumazet@google.com, gerrard.tai@starlabs.sg,
Pedro Tammela <pctammela@mojatatu.com>
Subject: Re: [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL with HTB parent
Date: Wed, 2 Apr 2025 22:23:22 -0300 [thread overview]
Message-ID: <90069d47-8963-4caf-acdf-0577c19e999d@mojatatu.com> (raw)
In-Reply-To: <CAM_iQpW7f5QJRXBpEMAmMVNvF5aGk_2YNLVF=bcnoZhMhjDU4A@mail.gmail.com>
On 02/04/2025 21:40, Cong Wang wrote:
> On Sun, Mar 30, 2025 at 4:32 PM Cong Wang <xiyou.wangcong@gmail.com> wrote:
>>
>> On Sun, Mar 30, 2025 at 06:05:06PM -0300, Victor Nogueira wrote:
>>> On 28/03/2025 17:35, Cong Wang wrote:
>>>> On Sun, Mar 23, 2025 at 07:48:39PM -0300, Victor Nogueira wrote:
>>>>> On 20/03/2025 20:25, Cong Wang wrote:
>>>>>> Add a test case for CODEL with HTB parent to verify packet drop
>>>>>> behavior when the queue becomes empty. This helps ensure proper
>>>>>> notification mechanisms between qdiscs.
>>>>>>
>>>>>> Note this is best-effort, it is hard to play with those parameters
>>>>>> perfectly to always trigger ->qlen_notify().
>>>>>>
>>>>>> Cc: Pedro Tammela <pctammela@mojatatu.com>
>>>>>> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
>>>>>
>>>>> Cong, can you double check this test?
>>>>> I ran all of your other tests and they all succeeded, however
>>>>> this one specifically is always failing:
>>>>
>>>> Interesting, I thought I completely fixed this before posting after several
>>>> rounds of playing with the parameters. I will double check it, maybe it
>>>> just becomes less reproducible.
>>>
>>> I see.
>>> I experimented with it a bit today and found out that changing the ping
>>> command to:
>>>
>>> ping -c 2 -i 0 -s 1500 -I $DUMMY 10.10.10.1 > /dev/null || true
>>>
>>> makes the test pass consistently (at least in my environment).
>>> So essentially just changing the "-s" option to 1500.
>>>
>>> If you could, please try it out as well.
>>> Maybe I just got lucky.
>>
>> Sure, I will change it to 1500.
>
> Hmm, it failed on my side:
>
> Test a4bd: Test CODEL with HTB parent - force packet drop with empty queue
> [...]
I see, this test seems to be very environment sensitive.
I think it will be better if we do what you suggested earlier.
It's not fair to stall this set because of this single test.
Can you resend your patches excluding this test?
I can try and figure this one out later so that we can
unblock.
cheers,
Victor
next prev parent reply other threads:[~2025-04-03 1:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 23:21 [Patch net 00/12] net_sched: make ->qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 01/12] sch_htb: make htb_qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 02/12] sch_drr: make drr_qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 03/12] sch_hfsc: make hfsc_qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 04/12] sch_qfq: make qfq_qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 05/12] sch_ets: make est_qlen_notify() idempotent Cong Wang
2025-03-20 23:25 ` [Patch net 06/12] codel: remove sch->q.qlen check before qdisc_tree_reduce_backlog() Cong Wang
2025-03-20 23:25 ` [Patch net 07/12] selftests/tc-testing: Add a test case for FQ_CODEL with HTB parent Cong Wang
2025-03-20 23:25 ` [Patch net 08/12] selftests/tc-testing: Add a test case for CODEL " Cong Wang
2025-03-23 22:48 ` Victor Nogueira
2025-03-28 20:35 ` Cong Wang
2025-03-30 21:05 ` Victor Nogueira
2025-03-30 23:32 ` Cong Wang
2025-04-03 0:40 ` Cong Wang
2025-04-03 1:23 ` Victor Nogueira [this message]
2025-04-03 19:32 ` Cong Wang
2025-03-20 23:25 ` [Patch net 09/12] selftests/tc-testing: Add a test case for FQ_CODEL with QFQ parent Cong Wang
2025-03-20 23:25 ` [Patch net 10/12] selftests/tc-testing: Add a test case for FQ_CODEL with HFSC parent Cong Wang
2025-03-20 23:25 ` [Patch net 11/12] selftests/tc-testing: Add a test case for FQ_CODEL with DRR parent Cong Wang
2025-03-20 23:25 ` [Patch net 12/12] selftests/tc-testing: Add a test case for FQ_CODEL with ETS parent Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90069d47-8963-4caf-acdf-0577c19e999d@mojatatu.com \
--to=victor@mojatatu.com \
--cc=edumazet@google.com \
--cc=gerrard.tai@starlabs.sg \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pctammela@mojatatu.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox