[PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Selvamani Rajagopal]

According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
specification, interrupt type is active low, level triggered interrupt.

Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY")
Signed-off-by: Selvamani Rajagopal <Selvamani.Rajagopal@onsemi.com>
---
 Documentation/devicetree/bindings/net/microchip,lan8650.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/microchip,lan8650.yaml b/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
index 61e11d4a07c4..766ff58147ae 100644
--- a/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
+++ b/Documentation/devicetree/bindings/net/microchip,lan8650.yaml
@@ -67,7 +67,7 @@ examples:
         pinctrl-names = "default";
         pinctrl-0 = <&eth0_pins>;
         interrupt-parent = <&gpio>;
-        interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
+        interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
         local-mac-address = [04 05 06 01 02 03];
         spi-max-frequency = <15000000>;
       };
-- 
2.43.0

Re: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Krzysztof Kozlowski]

On 15/05/2026 18:13, Selvamani Rajagopal wrote:
> According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
> specification, interrupt type is active low, level triggered interrupt.
> 
> Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY")

Drop, there is no bug here. That is only an example. Otherwise explain
how does this bug affect anything.

Also, did you consider the board layout?

Best regards,
Krzysztof

Re: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Andrew Lunn]

> Also, did you consider the board layout?

Hum. How would a board design convert a level interrupt into an edge
interrupt?

Use the level signal to gate a clock signal? So while the interrupt is
low, you get a stream of edges? Does that really exist?

     Andrew

RE: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Selvamani Rajagopal]

> 
> 
> This Message Is From an External Sender
> This message came from outside your organization.
> 
> On 15/05/2026 18:13, Selvamani Rajagopal wrote:
> > According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
> > specification, interrupt type is active low, level triggered interrupt.
> >
> > Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S
> MACPHY")
> 
> Drop, there is no bug here. That is only an example. Otherwise explain
> how does this bug affect anything.

Couple of reasons:
1) Agree. This is just an example. The reason I changed the YAML file is, due to the change in corresponding the source code change patch 1/2. I thought this entry should match with what is used in the source code.
2) We have our own TC6 compliant driver that is under review net-next repo that is going to have these changes. We were told to submit the fixes (specifically patch 1/2) to the existing code in net repo, not net-next repo.

> 
> Also, did you consider the board layout?

I believe standard (OPEN Alliance) calls for active low, level triggered interrupt. That is the reason for these two patches. 
BTW, Just saw Andrew's response on this.

> 
> Best regards,
> Krzysztof

Re: [PATCH net 2/2] dt-bindings: net: updated interrupt type to be active low, level triggered

[Andrew Lunn]

On Fri, May 15, 2026 at 06:15:50PM +0200, Krzysztof Kozlowski wrote:
> On 15/05/2026 18:13, Selvamani Rajagopal wrote:
> > According to OPEN Alliance 10BASE-T1x MACPHY Serial Interface (TC6)
> > specification, interrupt type is active low, level triggered interrupt.
> > 
> > Fixes: ac49b950bea9 ("dt-bindings: net: add Microchip's LAN865X 10BASE-T1S MACPHY")
> 
> Drop, there is no bug here. That is only an example. Otherwise explain
> how does this bug affect anything.

There is a tendency for DT developers to just copy/paste the example,
and not really engage brain. So if the example is wrong, the .dts file
will be wrong.

The thing about edge interrupts when level should be used is that they
mostly work. So quick smoke testing is not going to see any problems,
it is only when some condition comes along which causes two interrupts
in quick succession will the interface grind to a halt due to a missed
interrupt.

So i think it is a useful fix to have in stable.

	Andrew