From: Julian Anastasov <ja@ssi.bg>
To: WangYuli <wangyuli@uniontech.com>
Cc: Simon Horman <horms@verge.net.au>,
pablo@netfilter.org, kadlec@netfilter.org,
netdev@vger.kernel.org, lvs-devel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
linux-kernel <linux-kernel@vger.kernel.org>,
zhanjun@uniontech.com, niecheng1@uniontech.com,
guanwentao@uniontech.com, wangyuli@cloudflare.getdeepin.org
Subject: Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comment
Date: Fri, 4 Jul 2025 12:52:57 +0300 (EEST) [thread overview]
Message-ID: <3dbee3f4-8670-b72c-e5b0-3a108b5ded04@ssi.bg> (raw)
In-Reply-To: <E5403EE80920424D+20250704083553.313144-1-wangyuli@uniontech.com>
Hello,
On Fri, 4 Jul 2025, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
> switched del_timer to timer_delete, but did not modify the comment for
> ip_vs_conn_expire_now(). Now fix it.
>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
Looks good to me for nf-next, thanks!
Acked-by: Julian Anastasov <ja@ssi.bg>
> ---
> net/netfilter/ipvs/ip_vs_conn.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index 44b2ad695c15..965f3c8e5089 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -926,7 +926,7 @@ static void ip_vs_conn_expire(struct timer_list *t)
> void ip_vs_conn_expire_now(struct ip_vs_conn *cp)
> {
> /* Using mod_timer_pending will ensure the timer is not
> - * modified after the final del_timer in ip_vs_conn_expire.
> + * modified after the final timer_delete in ip_vs_conn_expire.
> */
> if (timer_pending(&cp->timer) &&
> time_after(cp->timer.expires, jiffies))
> --
> 2.50.0
Regards
--
Julian Anastasov <ja@ssi.bg>
next prev parent reply other threads:[~2025-07-04 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 8:35 [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comment WangYuli
2025-07-04 9:52 ` Julian Anastasov [this message]
2025-07-22 3:25 ` Pablo Neira Ayuso
2025-07-22 8:05 ` WangYuli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dbee3f4-8670-b72c-e5b0-3a108b5ded04@ssi.bg \
--to=ja@ssi.bg \
--cc=coreteam@netfilter.org \
--cc=guanwentao@uniontech.com \
--cc=horms@verge.net.au \
--cc=kadlec@netfilter.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=niecheng1@uniontech.com \
--cc=pablo@netfilter.org \
--cc=wangyuli@cloudflare.getdeepin.org \
--cc=wangyuli@uniontech.com \
--cc=zhanjun@uniontech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox