Netdev List
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: WangYuli <wangyuli@uniontech.com>
Cc: horms@verge.net.au, ja@ssi.bg, kadlec@netfilter.org,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	lvs-devel@vger.kernel.org, netfilter-devel@vger.kernel.org,
	coreteam@netfilter.org, linux-kernel@vger.kernel.org,
	zhanjun@uniontech.com, niecheng1@uniontech.com,
	guanwentao@uniontech.com, wangyuli@deepin.org
Subject: Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comment
Date: Tue, 22 Jul 2025 05:25:07 +0200	[thread overview]
Message-ID: <aH8Ek6XA_EFr_XWh@calendula> (raw)
In-Reply-To: <E5403EE80920424D+20250704083553.313144-1-wangyuli@uniontech.com>

On Fri, Jul 04, 2025 at 04:35:53PM +0800, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
> switched del_timer to timer_delete, but did not modify the comment for
> ip_vs_conn_expire_now(). Now fix it.

$ git grep del_timer net/netfilter/
net/netfilter/ipvs/ip_vs_lblc.c: *     Julian Anastasov        :    replaced del_timer call with del_timer_sync
net/netfilter/ipvs/ip_vs_lblc.c: *                                   handler and del_timer thread in SMP

Wider search, in the net tree:

net/ipv4/igmp.c: *                                      which caused a "del_timer() called
net/ipv4/igmp.c: *              Christian Daudt :       removed del_timer from

Maybe these are only for historical purpose, so leaving them untouched
is fine.

  parent reply	other threads:[~2025-07-22  3:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04  8:35 [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comment WangYuli
2025-07-04  9:52 ` Julian Anastasov
2025-07-22  3:25 ` Pablo Neira Ayuso [this message]
2025-07-22  8:05   ` WangYuli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aH8Ek6XA_EFr_XWh@calendula \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=guanwentao@uniontech.com \
    --cc=horms@verge.net.au \
    --cc=ja@ssi.bg \
    --cc=kadlec@netfilter.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvs-devel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=niecheng1@uniontech.com \
    --cc=pabeni@redhat.com \
    --cc=wangyuli@deepin.org \
    --cc=wangyuli@uniontech.com \
    --cc=zhanjun@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox