Netdev List
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Lars Kellogg-Stedman <lars@oddbit.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
	linux-hams@vger.kernel.org, netdev@vger.kernel.org,
	Duoming Zhou <duoming@zju.edu.cn>
Subject: Re: [PATCH v4] ax25: Fix refcount imbalance on inbound connections
Date: Wed, 29 May 2024 18:20:22 +0300	[thread overview]
Message-ID: <3ea61b17-c893-46ae-a338-090cf1c6618a@moroto.mountain> (raw)
In-Reply-To: <7bfn3g46beatmbp3bzxauahdiitb67ncfixp6znjdc6e5gj6mc@ldmt3i2wnqpf>

On Wed, May 29, 2024 at 10:54:45AM -0400, Lars Kellogg-Stedman wrote:
> > 3) The other thing that I notice is that Duoming dropped part of his
> > commit when he resent v6.
> > https://lore.kernel.org/all/5c61fea1b20f3c1596e4fb46282c3dedc54513a3.1715065005.git.duoming@zju.edu.cn/
> > That part of the commit was correct.  Maybe it wasn't necessary but it
> > feels right and it's more readable and it's obviously harmless.  I can
> > resend that.
> 
> Just so that I'm clear, with that comment you're not suggesting any
> changes to my patch, right?

No, I just noticed it while reviewing the code.  I'll take care of it.

regards,
dan carpenter


  reply	other threads:[~2024-05-29 15:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 18:31 [PATCH v4] ax25: Fix refcount imbalance on inbound connections lars
2024-05-23 15:05 ` Dan Carpenter
2024-05-23 15:22   ` Dan Cross
2024-05-23 18:23     ` Dan Carpenter
2024-05-23 20:39       ` Dan Cross
2024-05-24 15:25         ` Lars Kellogg-Stedman
2024-05-24 15:47           ` Dan Cross
2024-05-27  6:54           ` Dan Carpenter
2024-05-28  9:40 ` Paolo Abeni
2024-05-28 16:06   ` Lars Kellogg-Stedman
2024-05-29 14:34     ` Dan Carpenter
2024-05-29 14:54       ` Lars Kellogg-Stedman
2024-05-29 15:20         ` Dan Carpenter [this message]
2024-05-29 15:01       ` duoming
2024-05-29 15:22         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ea61b17-c893-46ae-a338-090cf1c6618a@moroto.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=duoming@zju.edu.cn \
    --cc=lars@oddbit.com \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox