From: Dan Carpenter <dan.carpenter@linaro.org>
To: Lars Kellogg-Stedman <lars@oddbit.com>
Cc: Dan Cross <crossd@gmail.com>, Duoming Zhou <duoming@zju.edu.cn>,
linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v4] ax25: Fix refcount imbalance on inbound connections
Date: Mon, 27 May 2024 09:54:27 +0300 [thread overview]
Message-ID: <582ff355-683b-4451-9443-d5adca154fa0@moroto.mountain> (raw)
In-Reply-To: <wq52rxvjp64uk65rhoh245d5immjll7lat6f6lmjbrc2cru6ej@wnronkmoqbyr>
On Fri, May 24, 2024 at 11:25:36AM -0400, Lars Kellogg-Stedman wrote:
> On Thu, May 23, 2024 at 04:39:27PM GMT, Dan Cross wrote:
> > On Thu, May 23, 2024 at 2:23 PM Dan Carpenter <dan.carpenter@linaro.org> wrote:
> > > The problem is that accept() and ax25_release() are not mirrored pairs.
>
> Right, but my in making this patch I wasn't thinking so much about
> accept/ax25_release, which as you say are not necessarily a mirrored
> pair...
>
> > It seems clear that this will happen for sockets that have a ref on
> > the device either via `bind` or via `accept`.
>
> ...but rather bind/accept, which *are*. The patch I've submitted gives
> us equivalent behavior on the code paths for inbound and outbound
> connections.
This is the explanation I was looking for. Sorry, I meant to review
these patches again over the weekend but I got caught up in other things.
Give me until tomorrow to review it again.
regards,
dan carpenter
next prev parent reply other threads:[~2024-05-27 6:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 18:31 [PATCH v4] ax25: Fix refcount imbalance on inbound connections lars
2024-05-23 15:05 ` Dan Carpenter
2024-05-23 15:22 ` Dan Cross
2024-05-23 18:23 ` Dan Carpenter
2024-05-23 20:39 ` Dan Cross
2024-05-24 15:25 ` Lars Kellogg-Stedman
2024-05-24 15:47 ` Dan Cross
2024-05-27 6:54 ` Dan Carpenter [this message]
2024-05-28 9:40 ` Paolo Abeni
2024-05-28 16:06 ` Lars Kellogg-Stedman
2024-05-29 14:34 ` Dan Carpenter
2024-05-29 14:54 ` Lars Kellogg-Stedman
2024-05-29 15:20 ` Dan Carpenter
2024-05-29 15:01 ` duoming
2024-05-29 15:22 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=582ff355-683b-4451-9443-d5adca154fa0@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=crossd@gmail.com \
--cc=duoming@zju.edu.cn \
--cc=lars@oddbit.com \
--cc=linux-hams@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox