* [PATCH ethtool] ethtool: document WoL filters option also in help message
@ 2018-08-17 13:21 Michal Kubecek
2018-08-17 17:51 ` Florian Fainelli
0 siblings, 1 reply; 3+ messages in thread
From: Michal Kubecek @ 2018-08-17 13:21 UTC (permalink / raw)
To: John W. Linville; +Cc: Florian Fainelli, netdev
Commit eff0bb337223 ("ethtool: Add support for WAKE_FILTER (WoL using
filters)") added option "f" for wake on lan and documented it in man page
but not in the output of "ethtool --help".
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
ethtool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ethtool.c b/ethtool.c
index aa2bbe9e4c65..e8b7703293d2 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -5069,7 +5069,7 @@ static const struct option {
" [ advertise %x ]\n"
" [ phyad %d ]\n"
" [ xcvr internal|external ]\n"
- " [ wol p|u|m|b|a|g|s|d... ]\n"
+ " [ wol p|u|m|b|a|g|s|f|d... ]\n"
" [ sopass %x:%x:%x:%x:%x:%x ]\n"
" [ msglvl %d | msglvl type on|off ... ]\n" },
{ "-a|--show-pause", 1, do_gpause, "Show pause options" },
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH ethtool] ethtool: document WoL filters option also in help message
2018-08-17 13:21 [PATCH ethtool] ethtool: document WoL filters option also in help message Michal Kubecek
@ 2018-08-17 17:51 ` Florian Fainelli
2018-08-18 21:35 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Florian Fainelli @ 2018-08-17 17:51 UTC (permalink / raw)
To: Michal Kubecek, John W. Linville; +Cc: netdev
On 08/17/2018 06:21 AM, Michal Kubecek wrote:
> Commit eff0bb337223 ("ethtool: Add support for WAKE_FILTER (WoL using
> filters)") added option "f" for wake on lan and documented it in man page
> but not in the output of "ethtool --help".
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Thanks Michal!
--
Florian
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ethtool] ethtool: document WoL filters option also in help message
2018-08-17 17:51 ` Florian Fainelli
@ 2018-08-18 21:35 ` John W. Linville
0 siblings, 0 replies; 3+ messages in thread
From: John W. Linville @ 2018-08-18 21:35 UTC (permalink / raw)
To: Florian Fainelli; +Cc: Michal Kubecek, netdev
On Fri, Aug 17, 2018 at 10:51:31AM -0700, Florian Fainelli wrote:
> On 08/17/2018 06:21 AM, Michal Kubecek wrote:
> > Commit eff0bb337223 ("ethtool: Add support for WAKE_FILTER (WoL using
> > filters)") added option "f" for wake on lan and documented it in man page
> > but not in the output of "ethtool --help".
> >
> > Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
>
> Acked-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Thanks Michal!
Yes, good eye!
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-19 0:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-17 13:21 [PATCH ethtool] ethtool: document WoL filters option also in help message Michal Kubecek
2018-08-17 17:51 ` Florian Fainelli
2018-08-18 21:35 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox