Netdev List
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Carlos Fernandez <carlos.fernandez@technica-engineering.de>
Cc: Sabrina Dubroca <sd@queasysnail.net>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] macsec: MACsec SCI assignment for ES = 0
Date: Tue, 3 Jun 2025 10:18:57 +0200	[thread overview]
Message-ID: <440438c8-8cef-4114-9d5a-3a80faa5fcd2@redhat.com> (raw)
In-Reply-To: <20250603080618.1727268-1-carlos.fernandez@technica-engineering.de>

On 6/3/25 10:06 AM, Carlos Fernandez wrote:
> I'll ammend the patch and send it to net-next instead.

While at it:
- please include the changelog comprising a reference (URL) to the prior
discussion after the tag area and a '---' separator
- please include the patch revision in the subj prefix (v5 AFAICS)
- consider extracting the active sci lookup logic in a separate helper,
will probably simplify the code and will reduce the indentation.

Thanks,

Paolo


  reply	other threads:[~2025-06-03  8:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-29 12:44 [PATCH net] macsec: MACsec SCI assignment for ES = 0 carlos.fernandez
2025-06-03  7:04 ` Subbaraya Sundeep
2025-06-03  8:06 ` Carlos Fernandez
2025-06-03  8:18   ` Paolo Abeni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-06-04 12:33 [PATCH net v3] " carlos.fernandez
2025-06-05 13:17 ` [PATCH net] " Carlos Fernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=440438c8-8cef-4114-9d5a-3a80faa5fcd2@redhat.com \
    --to=pabeni@redhat.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=carlos.fernandez@technica-engineering.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox