Netdev List
 help / color / mirror / Atom feed
* [BUG] renesas/sh_eth: two possible sleep-in-atomic bugs in sh_eth_set_link_ksettings and sh_eth_nway_reset
@ 2017-12-13  3:39 Jia-Ju Bai
  0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2017-12-13  3:39 UTC (permalink / raw)
  To: sergei.shtylyov, davem, niklas.soderlund+renesas, geert+renesas,
	laurent.pinchart, horms+renesas
  Cc: netdev, linux-renesas-soc, Linux Kernel Mailing List

Accoring to drivers/net/ethernet/renesas/sh_eth.c, the driver may sleep 
under a spinlock.
The function call paths are:
sh_eth_set_link_ksettings (acquire the spinlock)
   phy_ethtool_ksettings_set
     phy_start_aneg
       phy_start_aneg_priv
         mutex_lock --> may sleep

sh_eth_nway_reset (acquire the spinlock)
   phy_start_aneg
     phy_start_aneg_priv
       mutex_lock --> may sleep

I do not find a good way to fix them, so I only report.
These possible bugs are found by my static analysis tool (DSAC) and 
checked by my code review.


Thanks,
Jia-Ju Bai

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-12-13  3:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-13  3:39 [BUG] renesas/sh_eth: two possible sleep-in-atomic bugs in sh_eth_set_link_ksettings and sh_eth_nway_reset Jia-Ju Bai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox