* [PATCH] qed: select ZLIB_INFLATE
@ 2015-11-10 10:28 Arnd Bergmann
2015-11-10 20:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-11-10 10:28 UTC (permalink / raw)
To: linux-kernel
Cc: Yuval Mintz, Ariel Elior, David S. Miller, everest-linux-l2,
netdev
The newly added qlogic qed driver uses the zlib library, but
misses the dependency:
drivers/built-in.o: In function `qed_alloc_stream_mem':
drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to `zlib_inflate_workspacesize'
drivers/built-in.o: In function `qed_unzip_data':
drivers/net/ethernet/qlogic/qed/qed_main.c:675: undefined reference to `zlib_inflateInit2'
This changes Kconfig to always select zlib when needed.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
---
Found on ARM randconfig builds
diff --git a/drivers/net/ethernet/qlogic/Kconfig b/drivers/net/ethernet/qlogic/Kconfig
index 30a6f246dfc9..ddcfcab034c2 100644
--- a/drivers/net/ethernet/qlogic/Kconfig
+++ b/drivers/net/ethernet/qlogic/Kconfig
@@ -94,6 +94,7 @@ config NETXEN_NIC
config QED
tristate "QLogic QED 25/40/100Gb core driver"
depends on PCI
+ select ZLIB_INFLATE
---help---
This enables the support for ...
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] qed: select ZLIB_INFLATE
2015-11-10 10:28 [PATCH] qed: select ZLIB_INFLATE Arnd Bergmann
@ 2015-11-10 20:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-11-10 20:39 UTC (permalink / raw)
To: arnd; +Cc: linux-kernel, Yuval.Mintz, Ariel.Elior, everest-linux-l2, netdev
From: Arnd Bergmann <arnd@arndb.de>
Date: Tue, 10 Nov 2015 11:28:15 +0100
> The newly added qlogic qed driver uses the zlib library, but
> misses the dependency:
>
> drivers/built-in.o: In function `qed_alloc_stream_mem':
> drivers/net/ethernet/qlogic/qed/qed_main.c:707: undefined reference to `zlib_inflate_workspacesize'
> drivers/built-in.o: In function `qed_unzip_data':
> drivers/net/ethernet/qlogic/qed/qed_main.c:675: undefined reference to `zlib_inflateInit2'
>
> This changes Kconfig to always select zlib when needed.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: fe56b9e6a8d9 ("qed: Add module with basic common support")
> ---
> Found on ARM randconfig builds
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-10 20:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-10 10:28 [PATCH] qed: select ZLIB_INFLATE Arnd Bergmann
2015-11-10 20:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox