* [DECNET] ROUTE: remove unecessary alignment
@ 2008-02-08 7:21 Eric Dumazet
2008-02-08 7:30 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2008-02-08 7:21 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
Same alignment requirement was removed on IP route cache in the past.
This alignment actually has bad effect on 32 bit arches, uniprocessor, since
sizeof(dn_rt_hash_bucket) is forced to 8 bytes instead of 4.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
[-- Attachment #2: dn_route.patch --]
[-- Type: text/plain, Size: 323 bytes --]
diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c
index 31be29b..9dc0abb 100644
--- a/net/decnet/dn_route.c
+++ b/net/decnet/dn_route.c
@@ -94,7 +94,7 @@ struct dn_rt_hash_bucket
{
struct dn_route *chain;
spinlock_t lock;
-} __attribute__((__aligned__(8)));
+};
extern struct neigh_table dn_neigh_table;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [DECNET] ROUTE: remove unecessary alignment
2008-02-08 7:21 [DECNET] ROUTE: remove unecessary alignment Eric Dumazet
@ 2008-02-08 7:30 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2008-02-08 7:30 UTC (permalink / raw)
To: dada1; +Cc: netdev
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Fri, 08 Feb 2008 08:21:06 +0100
> Same alignment requirement was removed on IP route cache in the past.
>
> This alignment actually has bad effect on 32 bit arches, uniprocessor, since
> sizeof(dn_rt_hash_bucket) is forced to 8 bytes instead of 4.
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Applied, anyone who shows love for DecNET deserves some love
in return :-)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-08 7:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-02-08 7:21 [DECNET] ROUTE: remove unecessary alignment Eric Dumazet
2008-02-08 7:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox