public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
* Re: [PATCH net-next] batman-adv: Fix spelling mistakes
  2021-06-02  6:56 [PATCH net-next] batman-adv: Fix spelling mistakes Zheng Yongjun
@ 2021-06-02  6:47 ` Sven Eckelmann
  2021-06-02  6:57   ` 答复: " zhengyongjun
  0 siblings, 1 reply; 3+ messages in thread
From: Sven Eckelmann @ 2021-06-02  6:47 UTC (permalink / raw)
  To: mareklindner, sw, a, davem, kuba, netdev, linux-kernel,
	Zheng Yongjun, b.a.t.m.a.n

[-- Attachment #1: Type: text/plain, Size: 659 bytes --]

On Wednesday, 2 June 2021 08:56:03 CEST Zheng Yongjun wrote:
> Fix some spelling mistakes in comments:
> containg  ==> containing
> dont  ==> don't
> datas  ==> data
> brodcast  ==> broadcast
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  net/batman-adv/bridge_loop_avoidance.c | 4 ++--
>  net/batman-adv/hard-interface.c        | 2 +-
>  net/batman-adv/hash.h                  | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)


You forgot to send it to the B.A.T.M.A.N. mailing list. And it therefore 
didn't appear in our patchwork. And you send stuff from the future - which is 
rather odd.

Applied anyway.

Thanks,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH net-next] batman-adv: Fix spelling mistakes
@ 2021-06-02  6:56 Zheng Yongjun
  2021-06-02  6:47 ` Sven Eckelmann
  0 siblings, 1 reply; 3+ messages in thread
From: Zheng Yongjun @ 2021-06-02  6:56 UTC (permalink / raw)
  To: mareklindner, sw, a, sven, davem, kuba, netdev, linux-kernel
  Cc: Zheng Yongjun

Fix some spelling mistakes in comments:
containg  ==> containing
dont  ==> don't
datas  ==> data
brodcast  ==> broadcast

Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
 net/batman-adv/bridge_loop_avoidance.c | 4 ++--
 net/batman-adv/hard-interface.c        | 2 +-
 net/batman-adv/hash.h                  | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index 7dc133cfc363..63d42dcc9324 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -395,7 +395,7 @@ static void batadv_bla_send_claim(struct batadv_priv *bat_priv, u8 *mac,
 		break;
 	case BATADV_CLAIM_TYPE_ANNOUNCE:
 		/* announcement frame
-		 * set HW SRC to the special mac containg the crc
+		 * set HW SRC to the special mac containing the crc
 		 */
 		ether_addr_copy(hw_src, mac);
 		batadv_dbg(BATADV_DBG_BLA, bat_priv,
@@ -1040,7 +1040,7 @@ static int batadv_check_claim_group(struct batadv_priv *bat_priv,
 	/* lets see if this originator is in our mesh */
 	orig_node = batadv_orig_hash_find(bat_priv, backbone_addr);
 
-	/* dont accept claims from gateways which are not in
+	/* don't accept claims from gateways which are not in
 	 * the same mesh or group.
 	 */
 	if (!orig_node)
diff --git a/net/batman-adv/hard-interface.c b/net/batman-adv/hard-interface.c
index 4a6a25d551a8..b99f64f483fc 100644
--- a/net/batman-adv/hard-interface.c
+++ b/net/batman-adv/hard-interface.c
@@ -403,7 +403,7 @@ int batadv_hardif_no_broadcast(struct batadv_hard_iface *if_outgoing,
 		goto out;
 	}
 
-	/* >1 neighbors -> (re)brodcast */
+	/* >1 neighbors -> (re)broadcast */
 	if (rcu_dereference(hlist_next_rcu(first)))
 		goto out;
 
diff --git a/net/batman-adv/hash.h b/net/batman-adv/hash.h
index 46696759f194..fb251c385a1b 100644
--- a/net/batman-adv/hash.h
+++ b/net/batman-adv/hash.h
@@ -18,7 +18,7 @@
 #include <linux/stddef.h>
 #include <linux/types.h>
 
-/* callback to a compare function.  should compare 2 element datas for their
+/* callback to a compare function.  should compare 2 element data for their
  * keys
  *
  * Return: true if same and false if not same
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* 答复: [PATCH net-next] batman-adv: Fix spelling mistakes
  2021-06-02  6:47 ` Sven Eckelmann
@ 2021-06-02  6:57   ` zhengyongjun
  0 siblings, 0 replies; 3+ messages in thread
From: zhengyongjun @ 2021-06-02  6:57 UTC (permalink / raw)
  To: Sven Eckelmann, mareklindner@neomailbox.ch, sw@simonwunderlich.de,
	a@unstable.cc, davem@davemloft.net, kuba@kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	b.a.t.m.a.n@lists.open-mesh.org

Thanks for your suggest :)
In fact, I send patch through the python script made by myself.

When I use command" ./scripts/get_maintainer.pl 0001-batman-adv-Fix-spelling-mistakes.patch", the information is:
```
Marek Lindner <mareklindner@neomailbox.ch> (maintainer:BATMAN ADVANCED)
Simon Wunderlich <sw@simonwunderlich.de> (maintainer:BATMAN ADVANCED)
Antonio Quartulli <a@unstable.cc> (maintainer:BATMAN ADVANCED)
Sven Eckelmann <sven@narfation.org> (maintainer:BATMAN ADVANCED)
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING [GENERAL])
Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING [GENERAL])
b.a.t.m.a.n@lists.open-mesh.org (moderated list:BATMAN ADVANCED)
netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
linux-kernel@vger.kernel.org (open list)
```

My send patch script forgot to deal with line like this(forgot deal with key word moderated list): " b.a.t.m.a.n@lists.open-mesh.org (moderated list:BATMAN ADVANCED)"
Therefore I forgot to send it to the B.A.T.M.A.N. mailing list.

I will fix this, thank you for your suggest :)

-----邮件原件-----
发件人: Sven Eckelmann [mailto:sven@narfation.org] 
发送时间: 2021年6月2日 14:47
收件人: mareklindner@neomailbox.ch; sw@simonwunderlich.de; a@unstable.cc; davem@davemloft.net; kuba@kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; zhengyongjun <zhengyongjun3@huawei.com>; b.a.t.m.a.n@lists.open-mesh.org
主题: Re: [PATCH net-next] batman-adv: Fix spelling mistakes

On Wednesday, 2 June 2021 08:56:03 CEST Zheng Yongjun wrote:
> Fix some spelling mistakes in comments:
> containg  ==> containing
> dont  ==> don't
> datas  ==> data
> brodcast  ==> broadcast
> 
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
>  net/batman-adv/bridge_loop_avoidance.c | 4 ++--
>  net/batman-adv/hard-interface.c        | 2 +-
>  net/batman-adv/hash.h                  | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)


You forgot to send it to the B.A.T.M.A.N. mailing list. And it therefore didn't appear in our patchwork. And you send stuff from the future - which is rather odd.

Applied anyway.

Thanks,
	Sven

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-02  6:57 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-02  6:56 [PATCH net-next] batman-adv: Fix spelling mistakes Zheng Yongjun
2021-06-02  6:47 ` Sven Eckelmann
2021-06-02  6:57   ` 答复: " zhengyongjun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox