From: Alexei Starovoitov <ast@fb.com>
To: John Fastabend <john.fastabend@gmail.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <daniel@iogearbox.net>
Subject: Re: [net PATCH 2/3] bpf: add support for sockmap detach programs
Date: Fri, 8 Sep 2017 15:38:47 -0700 [thread overview]
Message-ID: <4876e2ef-b093-cfb6-c1fd-c7f44ff891bb@fb.com> (raw)
In-Reply-To: <150490444956.11590.4733752227675213913.stgit@john-XPS-13-9360>
On 9/8/17 2:00 PM, John Fastabend wrote:
> The bpf map sockmap supports adding programs via attach commands. This
> patch adds the detach command to keep the API symmetric and allow
> users to remove previously added programs. Otherwise the user would
> have to delete the map and re-add it to get in this state.
>
> This also adds a series of additional tests to capture detach operation
> and also attaching/detaching invalid prog types.
>
> API note: socks will run (or not run) programs depending on the state
> of the map at the time the sock is added. We do not for example walk
> the map and remove programs from previously attached socks.
>
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Nice clean patch. Thx
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2017-09-08 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 21:00 [net PATCH 0/3] Fixes for XDP/BPF John Fastabend
2017-09-08 21:00 ` [net PATCH 1/3] net: rcu lock and preempt disable missing around generic xdp John Fastabend
2017-09-08 22:38 ` Alexei Starovoitov
2017-09-08 21:00 ` [net PATCH 2/3] bpf: add support for sockmap detach programs John Fastabend
2017-09-08 22:38 ` Alexei Starovoitov [this message]
2017-09-08 21:01 ` [net PATCH 3/3] bpf: devmap, use cond_resched instead of cpu_relax John Fastabend
2017-09-08 22:40 ` Alexei Starovoitov
2017-09-09 4:11 ` [net PATCH 0/3] Fixes for XDP/BPF David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876e2ef-b093-cfb6-c1fd-c7f44ff891bb@fb.com \
--to=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox