From: Alexei Starovoitov <ast@fb.com>
To: John Fastabend <john.fastabend@gmail.com>, <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <daniel@iogearbox.net>
Subject: Re: [net PATCH 1/3] net: rcu lock and preempt disable missing around generic xdp
Date: Fri, 8 Sep 2017 15:38:14 -0700 [thread overview]
Message-ID: <94e9e0f9-403a-72c7-62d2-797f6fd1bc99@fb.com> (raw)
In-Reply-To: <150490443011.11590.2847947557652786219.stgit@john-XPS-13-9360>
On 9/8/17 2:00 PM, John Fastabend wrote:
> do_xdp_generic must be called inside rcu critical section with preempt
> disabled to ensure BPF programs are valid and per-cpu variables used
> for redirect operations are consistent. This patch ensures this is true
> and fixes the splat below.
>
> The netif_receive_skb_internal() code path is now broken into two rcu
> critical sections. I decided it was better to limit the preempt_enable/disable
> block to just the xdp static key portion and the fallout is more
> rcu_read_lock/unlock calls. Seems like the best option to me.
>
> [ 607.596901] =============================
> [ 607.596906] WARNING: suspicious RCU usage
> [ 607.596912] 4.13.0-rc4+ #570 Not tainted
> [ 607.596917] -----------------------------
> [ 607.596923] net/core/dev.c:3948 suspicious rcu_dereference_check() usage!
> [ 607.596927]
> [ 607.596927] other info that might help us debug this:
> [ 607.596927]
> [ 607.596933]
> [ 607.596933] rcu_scheduler_active = 2, debug_locks = 1
> [ 607.596938] 2 locks held by pool/14624:
> [ 607.596943] #0: (rcu_read_lock_bh){......}, at: [<ffffffff95445ffd>] ip_finish_output2+0x14d/0x890
> [ 607.596973] #1: (rcu_read_lock_bh){......}, at: [<ffffffff953c8e3a>] __dev_queue_xmit+0x14a/0xfd0
> [ 607.597000]
> [ 607.597000] stack backtrace:
> [ 607.597006] CPU: 5 PID: 14624 Comm: pool Not tainted 4.13.0-rc4+ #570
> [ 607.597011] Hardware name: Dell Inc. Precision Tower 5810/0HHV7N, BIOS A17 03/01/2017
> [ 607.597016] Call Trace:
> [ 607.597027] dump_stack+0x67/0x92
> [ 607.597040] lockdep_rcu_suspicious+0xdd/0x110
> [ 607.597054] do_xdp_generic+0x313/0xa50
> [ 607.597068] ? time_hardirqs_on+0x5b/0x150
> [ 607.597076] ? mark_held_locks+0x6b/0xc0
> [ 607.597088] ? netdev_pick_tx+0x150/0x150
> [ 607.597117] netif_rx_internal+0x205/0x3f0
> [ 607.597127] ? do_xdp_generic+0xa50/0xa50
> [ 607.597144] ? lock_downgrade+0x2b0/0x2b0
> [ 607.597158] ? __lock_is_held+0x93/0x100
> [ 607.597187] netif_rx+0x119/0x190
> [ 607.597202] loopback_xmit+0xfd/0x1b0
> [ 607.597214] dev_hard_start_xmit+0x127/0x4e0
>
> Fixes: d445516966dc ("net: xdp: support xdp generic on virtual devices")
> Fixes: b5cdae3291f7 ("net: Generic XDP")
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
argh, so it's due to virtual devices and loopback.
Not pretty, but have to agree I don't see another way of fixing it.
Acked-by: Alexei Starovoitov <ast@kernel.org>
next prev parent reply other threads:[~2017-09-08 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 21:00 [net PATCH 0/3] Fixes for XDP/BPF John Fastabend
2017-09-08 21:00 ` [net PATCH 1/3] net: rcu lock and preempt disable missing around generic xdp John Fastabend
2017-09-08 22:38 ` Alexei Starovoitov [this message]
2017-09-08 21:00 ` [net PATCH 2/3] bpf: add support for sockmap detach programs John Fastabend
2017-09-08 22:38 ` Alexei Starovoitov
2017-09-08 21:01 ` [net PATCH 3/3] bpf: devmap, use cond_resched instead of cpu_relax John Fastabend
2017-09-08 22:40 ` Alexei Starovoitov
2017-09-09 4:11 ` [net PATCH 0/3] Fixes for XDP/BPF David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94e9e0f9-403a-72c7-62d2-797f6fd1bc99@fb.com \
--to=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox