From: Andrew Lunn <andrew@lunn.ch>
To: Luke Howard <lukeh@padl.com>
Cc: netdev@vger.kernel.org, vladimir.oltean@nxp.com,
kieran@sienda.com, jcschroeder@gmail.com, max@huntershome.org
Subject: Re: [RFC net-next 2/5] net: dsa: mv88e6xxx: add MV88E6XXX_G1_ATU_CTL_MAC_AVB setter
Date: Sat, 27 Sep 2025 16:29:11 +0200 [thread overview]
Message-ID: <48a760f2-323f-4448-9d18-9fe651471cdb@lunn.ch> (raw)
In-Reply-To: <20250927070724.734933-3-lukeh@padl.com>
On Sat, Sep 27, 2025 at 05:07:05PM +1000, Luke Howard wrote:
> Add accessors for the MACAVB bit, which controls whether certain ATU bits cause
> the entry to be interpreted as AVB or NRL (non-rate-limiting) entries. This is
> necessary on switches such as the 88E6352 and 88E6240 that support both AVB and
> NRL ATU entries.
>
> Signed-off-by: Luke Howard <lukeh@padl.com>
> ---
> drivers/net/dsa/mv88e6xxx/global1.h | 2 ++
> drivers/net/dsa/mv88e6xxx/global1_atu.c | 17 +++++++++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/drivers/net/dsa/mv88e6xxx/global1.h b/drivers/net/dsa/mv88e6xxx/global1.h
> index 3dbb7a1b8fe11..74be4c485ab10 100644
> --- a/drivers/net/dsa/mv88e6xxx/global1.h
> +++ b/drivers/net/dsa/mv88e6xxx/global1.h
> @@ -112,6 +112,7 @@
> /* Offset 0x0A: ATU Control Register */
> #define MV88E6XXX_G1_ATU_CTL 0x0a
> #define MV88E6XXX_G1_ATU_CTL_LEARN2ALL 0x0008
> +#define MV88E6XXX_G1_ATU_CTL_MAC_AVB 0x8000
> #define MV88E6161_G1_ATU_CTL_HASH_MASK 0x0003
nitpick: The sorting in this file suggests that they are sorted
highest bits to lowest bits. So MAC_AVB should be before LEARN2ALL.
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2025-09-27 14:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-27 7:07 [RFC net-next 0/5] net: dsa: mv88e6xxx: support for 802.1Qav Luke Howard
2025-09-27 7:07 ` [RFC net-next 1/5] net: dsa: mv88e6xxx: add num_tx_queues to chip info structure Luke Howard
2025-09-27 7:07 ` [RFC net-next 2/5] net: dsa: mv88e6xxx: add MV88E6XXX_G1_ATU_CTL_MAC_AVB setter Luke Howard
2025-09-27 14:29 ` Andrew Lunn [this message]
2025-09-27 7:07 ` [RFC net-next 3/5] net: dsa: mv88e6xxx: MQPRIO support Luke Howard
2025-09-27 15:12 ` Andrew Lunn
2025-09-27 16:00 ` Luke Howard
2025-09-27 17:36 ` Andrew Lunn
2025-09-27 18:14 ` Luke Howard
2026-05-26 7:05 ` Luke Howard
2025-09-27 7:07 ` [RFC net-next 4/5] net: dsa: mv88e6xxx: CBS support Luke Howard
2025-09-27 7:07 ` [RFC net-next 5/5] dt-bindings: net: dsa: mv88e6xxx: add mv88e6xxx-avb-mode property Luke Howard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48a760f2-323f-4448-9d18-9fe651471cdb@lunn.ch \
--to=andrew@lunn.ch \
--cc=jcschroeder@gmail.com \
--cc=kieran@sienda.com \
--cc=lukeh@padl.com \
--cc=max@huntershome.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox