Re: [PATCH net v2 2/3] net: phy: remove phy ports upon probe failure

[Nicolai Buchwitz <nb@tipi-net.de>]

On 4.6.2026 10:02, Maxime Chevallier wrote:
> Hi Nicolai,
> 
> On 6/1/26 11:31, Nicolai Buchwitz wrote:
>> On 1.6.2026 10:40, Maxime Chevallier wrote:
>>> When phy_probe fails, let's clean the phy_ports that were 
>>> successfully
>>> added already.
>>> 
>>> Suggested-by: Nicolai Buchwitz <nb@tipi-net.de>
>>> Fixes: 589e934d2735 ("net: phy: Introduce PHY ports representation")
>>> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
>>> ---
>>>  drivers/net/phy/phy_device.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>> 
>>> diff --git a/drivers/net/phy/phy_device.c 
>>> b/drivers/net/phy/phy_device.c
>>> index 6ccbfacf7d1d..a171cbe2a74a 100644
>>> --- a/drivers/net/phy/phy_device.c
>>> +++ b/drivers/net/phy/phy_device.c
>>> @@ -3778,6 +3778,8 @@ static int phy_probe(struct device *dev)
>>>      return 0;
>>> 
>>>  out:
>>> +    phy_cleanup_ports(phydev);
>>> +
>>>      sfp_bus_del_upstream(phydev->sfp_bus);
>>>      phydev->sfp_bus = NULL;
>> 
>> Reviewed-by: Nicolai Buchwitz <nb@tipi-net.de>
> 
> I'll be moving phy_cleanup_ports(phydev); after the sfp cleanup,
> can I keep your review tag ?

Sure.

Thanks,
Nicolai

> [...]