From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, carlos.soto@broadcom.com,
justin.chen@broadcom.com, opendmb@gmail.com, nb@tipi-net.de,
bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org, kudzo51@gmail.com
Subject: Re: [PATCH net-next v2 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support
Date: Wed, 18 Nov 2026 16:53:33 -0800 [thread overview]
Message-ID: <4fd158ad-eafa-4627-b763-688aa9888132@broadcom.com> (raw)
In-Reply-To: <179504864758.3136.4762946821848645256@kernel.org>
On 11/18/26 16:37, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 5 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 2 · Low: 3
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The new C45 sequence issues an ADDR frame followed by a
> READ/WRITE frame through MDIO_CMD.
This was a real problem for wait_func implementations that return 0
without the controller being idle (bcmgenet_mii_wait()). It is fixed in
the next version: unimac_mdio_addr_c45() now polls MDIO_CMD for
START_BUSY to clear after wait_func returns, so the READ/WRITE frame is
never started while the ADDR frame is still on the wire.
> - [Medium] unimac_mdio_set_clause() (mdio-bcm-unimac.c:126-138) adds a
> read-modify-write of MDIO_CFG to the MDIO access path, and that RMW is…
Also valid, and fixed in the next version: unimac_mdio_resume() now
takes bus->mdio_lock around unimac_mdio_clk_set(), so the two MDIO_CFG
read-modify-writes are serialized.
> - [Low] This patch changes behaviour for existing users of the non-DT
> (ACPI) GENET path more than the commit message says.
The C45 scan does run there, since that instance does not mask any
address. It only probes addresses that have no C22 device, so it cannot
take the place of the C22 PHY that phy_find_first() returns on those
systems. The commit message now says so. The scan is also cheaper than
it was, since patch 1 now stops after a failing MMD and goes straight to
the MMD 0 probe.
> - [Low] The comment above MDIO_POLL_DELAY_US/MDIO_POLL_TIMEOUT_US (mdio-
> bcm-unimac.c:45-48: 'A C45 access is two frames, so a 1ms timeout…
Reworded in the next version, along with the comment in
unimac_mdio_poll(), to say that the timeout applies to each frame.
> - [Low] The driver now enables C45 on every controller it binds.
AFAICT, all controller HW support C45 and have the definitions for the
bits we are using.
pw-bot: cr
--
Florian
next prev parent reply other threads:[~2026-11-19 0:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 21:34 [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan Florian Fainelli
2026-11-17 9:33 ` Nicolai Buchwitz
2026-11-19 0:37 ` netdev-bot+sashiko
2026-11-19 0:48 ` Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 2/4] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 3/4] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-16 21:34 ` [PATCH net-next v2 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-17 12:36 ` Nicolai Buchwitz
2026-11-19 0:37 ` netdev-bot+sashiko
2026-11-19 0:53 ` Florian Fainelli [this message]
2026-11-16 22:38 ` [PATCH net-next v2 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Kordian Chmielewski
2026-11-17 12:36 ` Nicolai Buchwitz
2026-11-17 23:17 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fd158ad-eafa-4627-b763-688aa9888132@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=carlos.soto@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=kudzo51@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox