From: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
To: Mitch Williams <mitch.a.williams@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: Catherine Sullivan <catherine.sullivan@intel.com>,
Shannon Nelson <shannon.nelson@intel.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: i40e/i40e_ethtool.c weirdness?
Date: Thu, 20 Nov 2014 14:21:47 -0500 [thread overview]
Message-ID: <51793.1416511307@turing-police.cc.vt.edu> (raw)
[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]
(spotted while looking at a 'git bisect visualize' for something else)
After this commit:
Author: Mitch Williams <mitch.a.williams@intel.com> 2014-09-13 03:40:47
Committer: Jeff Kirsher <jeffrey.t.kirsher@intel.com> 2014-10-23 23:38:04
i40e: Add 10GBaseT support
Add driver support for 10GBaseT device.
we have the following chunk of code in i40e_ethtool.c:
case I40E_PHY_TYPE_10GBASE_SFPP_CU:
ecmd->supported = SUPPORTED_10000baseT_Full;
break;
case I40E_PHY_TYPE_1000BASE_KX:
case I40E_PHY_TYPE_1000BASE_T:
ecmd->supported = SUPPORTED_Autoneg |
SUPPORTED_10000baseT_Full |
SUPPORTED_1000baseT_Full |
SUPPORTED_100baseT_Full;
ecmd->advertising = ADVERTISED_Autoneg |
ADVERTISED_10000baseT_Full |
ADVERTISED_1000baseT_Full |
ADVERTISED_100baseT_Full;
break;
case I40E_PHY_TYPE_100BASE_TX:
ecmd->supported = SUPPORTED_Autoneg |
SUPPORTED_10000baseT_Full |
SUPPORTED_1000baseT_Full |
SUPPORTED_100baseT_Full;
ecmd->advertising = ADVERTISED_Autoneg |
ADVERTISED_10000baseT_Full |
ADVERTISED_1000baseT_Full |
ADVERTISED_100baseT_Full;
break;
case I40E_PHY_TYPE_SGMII:
ecmd->supported = SUPPORTED_Autoneg |
I'm confused by the fact that 2 cases that by name are 100M and 1G parts
got bits saying that 10G is "supported" - was that intentional?
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next reply other threads:[~2014-11-20 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 19:21 Valdis Kletnieks [this message]
2014-11-21 21:46 ` i40e/i40e_ethtool.c weirdness? Sullivan, Catherine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51793.1416511307@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=catherine.sullivan@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox