i40e/i40e_ethtool.c weirdness?

i40e/i40e_ethtool.c weirdness?

[Valdis Kletnieks]

[-- Attachment #1: Type: text/plain, Size: 1861 bytes --]

(spotted while looking at a 'git bisect visualize' for something else)

After this commit:

Author: Mitch Williams <mitch.a.williams@intel.com>  2014-09-13 03:40:47
Committer: Jeff Kirsher <jeffrey.t.kirsher@intel.com>  2014-10-23 23:38:04

    i40e: Add 10GBaseT support

    Add driver support for 10GBaseT device.

we have the following chunk of code in i40e_ethtool.c:

        case I40E_PHY_TYPE_10GBASE_SFPP_CU:
                ecmd->supported = SUPPORTED_10000baseT_Full;
                break;
        case I40E_PHY_TYPE_1000BASE_KX:
        case I40E_PHY_TYPE_1000BASE_T:
                ecmd->supported = SUPPORTED_Autoneg |
                                  SUPPORTED_10000baseT_Full |
                                  SUPPORTED_1000baseT_Full |
                                  SUPPORTED_100baseT_Full;
                ecmd->advertising = ADVERTISED_Autoneg |
                                    ADVERTISED_10000baseT_Full |
                                    ADVERTISED_1000baseT_Full |
                                    ADVERTISED_100baseT_Full;
                break;
        case I40E_PHY_TYPE_100BASE_TX:
                ecmd->supported = SUPPORTED_Autoneg |
                                  SUPPORTED_10000baseT_Full |
                                  SUPPORTED_1000baseT_Full |
                                  SUPPORTED_100baseT_Full;
                ecmd->advertising = ADVERTISED_Autoneg |
                                    ADVERTISED_10000baseT_Full |
                                    ADVERTISED_1000baseT_Full |
                                    ADVERTISED_100baseT_Full;
                break;
        case I40E_PHY_TYPE_SGMII:
                ecmd->supported = SUPPORTED_Autoneg |

I'm confused by the fact that 2 cases that by name are 100M and 1G parts
got bits saying that 10G is "supported" - was that intentional?


[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]

RE: i40e/i40e_ethtool.c weirdness?

[Sullivan, Catherine]

> From: Valdis Kletnieks [mailto:Valdis.Kletnieks@vt.edu]
> 
> (spotted while looking at a 'git bisect visualize' for something else)
> 
> After this commit:
> 
> Author: Mitch Williams <mitch.a.williams@intel.com>  2014-09-13 03:40:47
> Committer: Jeff Kirsher <jeffrey.t.kirsher@intel.com>  2014-10-23 23:38:04
> 
>     i40e: Add 10GBaseT support
> 
>     Add driver support for 10GBaseT device.
> 
> we have the following chunk of code in i40e_ethtool.c:
> 
>         case I40E_PHY_TYPE_10GBASE_SFPP_CU:
>                 ecmd->supported = SUPPORTED_10000baseT_Full;
>                 break;
>         case I40E_PHY_TYPE_1000BASE_KX:
>         case I40E_PHY_TYPE_1000BASE_T:
>                 ecmd->supported = SUPPORTED_Autoneg |
>                                   SUPPORTED_10000baseT_Full |
>                                   SUPPORTED_1000baseT_Full |
>                                   SUPPORTED_100baseT_Full;
>                 ecmd->advertising = ADVERTISED_Autoneg |
>                                     ADVERTISED_10000baseT_Full |
>                                     ADVERTISED_1000baseT_Full |
>                                     ADVERTISED_100baseT_Full;
>                 break;
>         case I40E_PHY_TYPE_100BASE_TX:
>                 ecmd->supported = SUPPORTED_Autoneg |
>                                   SUPPORTED_10000baseT_Full |
>                                   SUPPORTED_1000baseT_Full |
>                                   SUPPORTED_100baseT_Full;
>                 ecmd->advertising = ADVERTISED_Autoneg |
>                                     ADVERTISED_10000baseT_Full |
>                                     ADVERTISED_1000baseT_Full |
>                                     ADVERTISED_100baseT_Full;
>                 break;
>         case I40E_PHY_TYPE_SGMII:
>                 ecmd->supported = SUPPORTED_Autoneg |
> 
> I'm confused by the fact that 2 cases that by name are 100M and 1G parts got
> bits saying that 10G is "supported" - was that intentional?

Yes, it was intentional. The 100M and 1G phy types that got 10G support are actually 10G parts that show up as 100M and 1G when that is the link speed. All three phy types therefore need to support all three speeds so that it is possible to toggle between them. 

-Catherine