Netdev List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Andrew Lunn <andrew@lunn.ch>, Andrew Lunn <andrew+netdev@lunn.ch>,
	Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	David Miller <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used
Date: Thu, 11 Sep 2025 08:34:52 +0200	[thread overview]
Message-ID: <51e11917-e9c7-4708-a80f-f369874d2ed3@kernel.org> (raw)
In-Reply-To: <bca6866a-4840-4da0-a735-1a394baadbd8@gmail.com>

On 09/09/2025 21:16, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/phy/phylink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index c7f867b36..d3cb52717 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>  			return -EINVAL;
>  		}
>  
> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
> +			     fwnode_get_name(fwnode));
Similar comment as for patch #1 - this seems to be going to printk, so
use proper % format for fwnodes (I think there is as well such).

Best regards,
Krzysztof

  parent reply	other threads:[~2025-09-11  6:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-09 19:14 [PATCH net-next 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected Heiner Kallweit
2025-09-09 19:15 ` [PATCH net-next 1/2] of: mdio: warn if deprecated fixed-link binding is used Heiner Kallweit
2025-09-09 21:25   ` Andrew Lunn
2025-09-11  6:34   ` Krzysztof Kozlowski
2025-09-09 19:16 ` [PATCH net-next 2/2] net: phylink: warn if deprecated array-style " Heiner Kallweit
2025-09-09 21:27   ` Andrew Lunn
2025-09-10  6:29     ` Heiner Kallweit
2025-09-11  6:34   ` Krzysztof Kozlowski [this message]
2025-09-11 16:28     ` Heiner Kallweit
2025-09-11 16:44       ` Andrew Lunn
2025-09-11 16:58         ` Heiner Kallweit
2025-09-11 18:16           ` Krzysztof Kozlowski
2025-09-11  7:22 ` [PATCH net-next 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51e11917-e9c7-4708-a80f-f369874d2ed3@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox