Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Heiner Kallweit <hkallweit1@gmail.com>]

On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
> On 09/09/2025 21:16, Heiner Kallweit wrote:
>> The array-style fixed-link binding has been marked deprecated for more
>> than 10 yrs, but still there's a number of users. Print a warning when
>> usage of the deprecated binding is detected.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  drivers/net/phy/phylink.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>> index c7f867b36..d3cb52717 100644
>> --- a/drivers/net/phy/phylink.c
>> +++ b/drivers/net/phy/phylink.c
>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>>  			return -EINVAL;
>>  		}
>>  
>> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
>> +			     fwnode_get_name(fwnode));
> Similar comment as for patch #1 - this seems to be going to printk, so
> use proper % format for fwnodes (I think there is as well such).
> 
At least here no format for fwnodes is mentioned.
https://www.kernel.org/doc/Documentation/printk-formats.txt

> Best regards,
> Krzysztof