[PATCH net-next 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[PATCH net-next 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Heiner Kallweit (2):
  of: mdio: warn if deprecated fixed-link binding is used
  net: phylink: warn if deprecated array-style fixed-link binding is
    used

 drivers/net/mdio/of_mdio.c | 2 ++
 drivers/net/phy/phylink.c  | 3 +++
 2 files changed, 5 insertions(+)

-- 
2.51.0

[PATCH net-next 1/2] of: mdio: warn if deprecated fixed-link binding is used

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/mdio/of_mdio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
index d8ca63ed8..d35e28dbe 100644
--- a/drivers/net/mdio/of_mdio.c
+++ b/drivers/net/mdio/of_mdio.c
@@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np)
 	/* Old binding */
 	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
 				       ARRAY_SIZE(fixed_link_prop)) == 0) {
+		pr_warn_once("%s uses deprecated array-style fixed-link binding!",
+			     of_node_full_name(np));
 		status.link = 1;
 		status.duplex = fixed_link_prop[1];
 		status.speed  = fixed_link_prop[2];
-- 
2.51.0

[PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Heiner Kallweit]

The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/phy/phylink.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index c7f867b36..d3cb52717 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
 			return -EINVAL;
 		}
 
+		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
+			     fwnode_get_name(fwnode));
+
 		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
 						     prop, ARRAY_SIZE(prop));
 		if (!ret) {
-- 
2.51.0

Re: [PATCH net-next 1/2] of: mdio: warn if deprecated fixed-link binding is used

[Andrew Lunn]

On Tue, Sep 09, 2025 at 09:15:35PM +0200, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Andrew Lunn]

On Tue, Sep 09, 2025 at 09:16:36PM +0200, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

It should be a pretty mechanical transformation to convert them. How
many are there?

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Heiner Kallweit]

On 9/9/2025 11:27 PM, Andrew Lunn wrote:
> On Tue, Sep 09, 2025 at 09:16:36PM +0200, Heiner Kallweit wrote:
>> The array-style fixed-link binding has been marked deprecated for more
>> than 10 yrs, but still there's a number of users. Print a warning when
>> usage of the deprecated binding is detected.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> It should be a pretty mechanical transformation to convert them. How
> many are there?
> 

At first I looked only at the Arm DT's, but there are more users of the
old binding under arch/powerpc. In total it's 24 users.

arch/powerpc/boot/dts/mpc8313erdb.dts:                  fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/tqm8xx.dts:                               fixed-link = <0 0 10 0 0>;
arch/powerpc/boot/dts/mpc8378_rdb.dts:                  fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/mgcoge.dts:                               fixed-link = <0 0 10 0 0>;
arch/powerpc/boot/dts/mpc8308rdb.dts:                   fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/mpc8377_rdb.dts:                  fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/mpc8379_rdb.dts:                  fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/mpc8349emitx.dts:                 fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p1020rdb-pd.dts:                      fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p1020rdb-pc.dtsi:             fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p1025rdb.dtsi:                fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p1020mbg-pc.dtsi:             fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/t104xqds.dtsi:                                fixed-link = <0 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/t104xqds.dtsi:                                fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p1021rdb-pc.dtsi:             fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p2020rdb.dts:                 fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p2020rdb-pc.dtsi:             fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/t1040rdb.dts:                         fixed-link = <0 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/t1040rdb.dts:                         fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/fsl/p1020rdb.dtsi:                fixed-link = <1 1 1000 0 0>;
arch/powerpc/boot/dts/charon.dts:                       fixed-link = <1 1 100 0 0>;
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts:              fixed-link = <1 1 10000 0 0>;
arch/arm/boot/dts/nxp/ls/ls1021a-iot.dts:       fixed-link = <0 1 1000 0 0>;
arch/arm/boot/dts/st/stih418-b2199.dts:                 fixed-link = <0 1 1000 0 0>;

> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> 
>     Andrew

Re: [PATCH net-next 1/2] of: mdio: warn if deprecated fixed-link binding is used

[Krzysztof Kozlowski]

On 09/09/2025 21:15, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/mdio/of_mdio.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/mdio/of_mdio.c b/drivers/net/mdio/of_mdio.c
> index d8ca63ed8..d35e28dbe 100644
> --- a/drivers/net/mdio/of_mdio.c
> +++ b/drivers/net/mdio/of_mdio.c
> @@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np)
>  	/* Old binding */
>  	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,
>  				       ARRAY_SIZE(fixed_link_prop)) == 0) {
> +		pr_warn_once("%s uses deprecated array-style fixed-link binding!",

Please use proper % format specifier for nodes. See printk-formats.

> +			     of_node_full_name(np));
Best regards,
Krzysztof

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Krzysztof Kozlowski]

On 09/09/2025 21:16, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/phy/phylink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> index c7f867b36..d3cb52717 100644
> --- a/drivers/net/phy/phylink.c
> +++ b/drivers/net/phy/phylink.c
> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>  			return -EINVAL;
>  		}
>  
> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
> +			     fwnode_get_name(fwnode));
Similar comment as for patch #1 - this seems to be going to printk, so
use proper % format for fwnodes (I think there is as well such).

Best regards,
Krzysztof

Re: [PATCH net-next 0/2] net: phy: print warning if usage of deprecated array-style fixed-link binding is detected

[Heiner Kallweit]

On 9/9/2025 9:14 PM, Heiner Kallweit wrote:
> The array-style fixed-link binding has been marked deprecated for more
> than 10 yrs, but still there's a number of users. Print a warning when
> usage of the deprecated binding is detected.
> 
> Heiner Kallweit (2):
>   of: mdio: warn if deprecated fixed-link binding is used
>   net: phylink: warn if deprecated array-style fixed-link binding is
>     used
> 
>  drivers/net/mdio/of_mdio.c | 2 ++
>  drivers/net/phy/phylink.c  | 3 +++
>  2 files changed, 5 insertions(+)
> 
--
pw-bot: cr

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Heiner Kallweit]

On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
> On 09/09/2025 21:16, Heiner Kallweit wrote:
>> The array-style fixed-link binding has been marked deprecated for more
>> than 10 yrs, but still there's a number of users. Print a warning when
>> usage of the deprecated binding is detected.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  drivers/net/phy/phylink.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>> index c7f867b36..d3cb52717 100644
>> --- a/drivers/net/phy/phylink.c
>> +++ b/drivers/net/phy/phylink.c
>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>>  			return -EINVAL;
>>  		}
>>  
>> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
>> +			     fwnode_get_name(fwnode));
> Similar comment as for patch #1 - this seems to be going to printk, so
> use proper % format for fwnodes (I think there is as well such).
> 
At least here no format for fwnodes is mentioned.
https://www.kernel.org/doc/Documentation/printk-formats.txt

> Best regards,
> Krzysztof

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Andrew Lunn]

On Thu, Sep 11, 2025 at 06:28:03PM +0200, Heiner Kallweit wrote:
> On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
> > On 09/09/2025 21:16, Heiner Kallweit wrote:
> >> The array-style fixed-link binding has been marked deprecated for more
> >> than 10 yrs, but still there's a number of users. Print a warning when
> >> usage of the deprecated binding is detected.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> >> ---
> >>  drivers/net/phy/phylink.c | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
> >> index c7f867b36..d3cb52717 100644
> >> --- a/drivers/net/phy/phylink.c
> >> +++ b/drivers/net/phy/phylink.c
> >> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
> >>  			return -EINVAL;
> >>  		}
> >>  
> >> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
> >> +			     fwnode_get_name(fwnode));
> > Similar comment as for patch #1 - this seems to be going to printk, so
> > use proper % format for fwnodes (I think there is as well such).
> > 
> At least here no format for fwnodes is mentioned.
> https://www.kernel.org/doc/Documentation/printk-formats.txt

I could be reading it wrong, but:

https://elixir.bootlin.com/linux/v6.16.6/source/lib/vsprintf.c#L2432
https://elixir.bootlin.com/linux/v6.16.6/source/lib/vsprintf.c#L2522

	Andrew

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Heiner Kallweit]

On 9/11/2025 6:44 PM, Andrew Lunn wrote:
> On Thu, Sep 11, 2025 at 06:28:03PM +0200, Heiner Kallweit wrote:
>> On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
>>> On 09/09/2025 21:16, Heiner Kallweit wrote:
>>>> The array-style fixed-link binding has been marked deprecated for more
>>>> than 10 yrs, but still there's a number of users. Print a warning when
>>>> usage of the deprecated binding is detected.
>>>>
>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>> ---
>>>>  drivers/net/phy/phylink.c | 3 +++
>>>>  1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>>>> index c7f867b36..d3cb52717 100644
>>>> --- a/drivers/net/phy/phylink.c
>>>> +++ b/drivers/net/phy/phylink.c
>>>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>>>>  			return -EINVAL;
>>>>  		}
>>>>  
>>>> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
>>>> +			     fwnode_get_name(fwnode));
>>> Similar comment as for patch #1 - this seems to be going to printk, so
>>> use proper % format for fwnodes (I think there is as well such).
>>>
>> At least here no format for fwnodes is mentioned.
>> https://www.kernel.org/doc/Documentation/printk-formats.txt
> 
> I could be reading it wrong, but:
> 
> https://elixir.bootlin.com/linux/v6.16.6/source/lib/vsprintf.c#L2432
> https://elixir.bootlin.com/linux/v6.16.6/source/lib/vsprintf.c#L2522
> 
Ah, good. fwnode support was added more than 5 yrs ago, so documentation
seems to be very outdated.

> 	Andrew

Heiner

Re: [PATCH net-next 2/2] net: phylink: warn if deprecated array-style fixed-link binding is used

[Krzysztof Kozlowski]

On 11/09/2025 18:58, Heiner Kallweit wrote:
> On 9/11/2025 6:44 PM, Andrew Lunn wrote:
>> On Thu, Sep 11, 2025 at 06:28:03PM +0200, Heiner Kallweit wrote:
>>> On 9/11/2025 8:34 AM, Krzysztof Kozlowski wrote:
>>>> On 09/09/2025 21:16, Heiner Kallweit wrote:
>>>>> The array-style fixed-link binding has been marked deprecated for more
>>>>> than 10 yrs, but still there's a number of users. Print a warning when
>>>>> usage of the deprecated binding is detected.
>>>>>
>>>>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>>>>> ---
>>>>>  drivers/net/phy/phylink.c | 3 +++
>>>>>  1 file changed, 3 insertions(+)
>>>>>
>>>>> diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
>>>>> index c7f867b36..d3cb52717 100644
>>>>> --- a/drivers/net/phy/phylink.c
>>>>> +++ b/drivers/net/phy/phylink.c
>>>>> @@ -700,6 +700,9 @@ static int phylink_parse_fixedlink(struct phylink *pl,
>>>>>  			return -EINVAL;
>>>>>  		}
>>>>>  
>>>>> +		phylink_warn(pl, "%s uses deprecated array-style fixed-link binding!",
>>>>> +			     fwnode_get_name(fwnode));
>>>> Similar comment as for patch #1 - this seems to be going to printk, so
>>>> use proper % format for fwnodes (I think there is as well such).
>>>>
>>> At least here no format for fwnodes is mentioned.
>>> https://www.kernel.org/doc/Documentation/printk-formats.txt
No, you are looking at wrong file.

It is Documentation/core-api/printk-formats.rst

Best regards,
Krzysztof