Netdev List
 help / color / mirror / Atom feed
From: Amir Vadai <amirv@mellanox.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: <netdev@vger.kernel.org>
Subject: Re: question about drivers/net/ethernet/mellanox/mlx4/en_tx.c
Date: Wed, 28 Aug 2013 15:43:16 +0300	[thread overview]
Message-ID: <521DF064.7090100@mellanox.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1308271904520.2282@hadrien>

On 27/08/2013 20:07, Julia Lawall wrote:
> Hello,
> 
> I was wondering why in drivers/net/ethernet/mellanox/mlx4/en_tx.c there
> are a number of uses of dma_sync_single_for_cpu without corresponding uses
> of dma_sync_single_for_device (for example in mlx4_en_rx_skb)?  In most
> drivers they come together.
> 
> thanks,
> julia
> 

Hi Julia,

I guess you meant to en_rx.c and not en_tx.c

It looks like a bug.
The whole skb buffers allocation and mapping is expected to be
overhauled soon - and this will be fixed as part of it.

Thanks,
Amir

  reply	other threads:[~2013-08-28 12:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27 17:07 question about drivers/net/ethernet/mellanox/mlx4/en_tx.c Julia Lawall
2013-08-28 12:43 ` Amir Vadai [this message]
2013-08-28 12:48   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521DF064.7090100@mellanox.com \
    --to=amirv@mellanox.com \
    --cc=julia.lawall@lip6.fr \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox