From: Julia Lawall <julia.lawall@lip6.fr>
To: Amir Vadai <amirv@mellanox.com>
Cc: netdev@vger.kernel.org
Subject: Re: question about drivers/net/ethernet/mellanox/mlx4/en_tx.c
Date: Wed, 28 Aug 2013 14:48:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.02.1308281447500.2279@hadrien> (raw)
In-Reply-To: <521DF064.7090100@mellanox.com>
On Wed, 28 Aug 2013, Amir Vadai wrote:
> On 27/08/2013 20:07, Julia Lawall wrote:
> > Hello,
> >
> > I was wondering why in drivers/net/ethernet/mellanox/mlx4/en_tx.c there
> > are a number of uses of dma_sync_single_for_cpu without corresponding uses
> > of dma_sync_single_for_device (for example in mlx4_en_rx_skb)? In most
> > drivers they come together.
> >
> > thanks,
> > julia
> >
>
> Hi Julia,
>
> I guess you meant to en_rx.c and not en_tx.c
Oops, yes.
> It looks like a bug.
> The whole skb buffers allocation and mapping is expected to be
> overhauled soon - and this will be fixed as part of it.
OK, thanks for the explanation.
julia
prev parent reply other threads:[~2013-08-28 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-27 17:07 question about drivers/net/ethernet/mellanox/mlx4/en_tx.c Julia Lawall
2013-08-28 12:43 ` Amir Vadai
2013-08-28 12:48 ` Julia Lawall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1308281447500.2279@hadrien \
--to=julia.lawall@lip6.fr \
--cc=amirv@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox