Re: [PATCH net-next] mpls: Allow mpls_gso and mpls_router to be built as modules

[Robert Shearman <rshearma@brocade.com>]

On 10/03/15 17:17, Eric W. Biederman wrote:
> Robert Shearman <rshearma@brocade.com> writes:
>
>> CONFIG_MPLS=m doesn't result in a kernel module being built because it
>> applies to the net/mpls directory, rather than to .o files.
>>
>> So revert the MPLS menuitem to being a boolean and make MPLS_GSO and
>> MPLS_ROUTING tristates to allow mpls_gso and mpls_router modules to be
>> produced as desired.
>
> Good catch.  But I am pretty certain this does not result in the mpls
> routing code in af_mpls being built as a module either.

I'm pretty sure it does ;-)

   CC [M]  net/mpls/af_mpls.o
   LD [M]  net/mpls/mpls_router.o
   Building modules, stage 2.
   MODPOST 3010 modules
   LD [M]  net/mpls/mpls_router.ko

I deliberately split out the makefile rules so that the would be named 
mpls_router, rather than af_mpls to avoid any potential confusion with 
the mpls_gso module.

Thanks,
Rob