From: ebiederm@xmission.com (Eric W. Biederman)
To: Robert Shearman <rshearma@brocade.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] mpls: Allow mpls_gso and mpls_router to be built as modules
Date: Tue, 10 Mar 2015 12:17:42 -0500 [thread overview]
Message-ID: <87y4n4kc09.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <1426005479-21806-1-git-send-email-rshearma@brocade.com> (Robert Shearman's message of "Tue, 10 Mar 2015 16:37:59 +0000")
Robert Shearman <rshearma@brocade.com> writes:
> CONFIG_MPLS=m doesn't result in a kernel module being built because it
> applies to the net/mpls directory, rather than to .o files.
>
> So revert the MPLS menuitem to being a boolean and make MPLS_GSO and
> MPLS_ROUTING tristates to allow mpls_gso and mpls_router modules to be
> produced as desired.
Good catch. But I am pretty certain this does not result in the mpls
routing code in af_mpls being built as a module either.
Eric
next prev parent reply other threads:[~2015-03-10 17:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 16:37 [PATCH net-next] mpls: Allow mpls_gso and mpls_router to be built as modules Robert Shearman
2015-03-10 17:17 ` Eric W. Biederman [this message]
2015-03-10 18:05 ` Robert Shearman
2015-03-10 18:07 ` Eric W. Biederman
2015-03-11 20:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y4n4kc09.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rshearma@brocade.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox