From: <Arun.Ramadoss@microchip.com>
To: <tharvey@gateworks.com>
Cc: <andrew@lunn.ch>, <davem@davemloft.net>, <olteanv@gmail.com>,
<Woojung.Huh@microchip.com>, <linux-kernel@vger.kernel.org>,
<pabeni@redhat.com>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <UNGLinuxDriver@microchip.com>,
<kuba@kernel.org>
Subject: Re: [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering
Date: Thu, 16 Jan 2025 09:06:09 +0000 [thread overview]
Message-ID: <55858a5677f187e5847e7941d62f6f186f5d121c.camel@microchip.com> (raw)
In-Reply-To: <CAJ+vNU3sAhtSkTjuj2ZMfa02Qk1rh1-z=1unEabrB8UOdx8nFA@mail.gmail.com>
Hi Tim,
> Hi Arun,
>
> Ok, that makes sense to me and falls in line with what my patch here
> was trying to do. When you enable the reserved multicast table it
> makes sense to update the entire table right? You are only updating
> one address/group. Can you please review and comment on my patch
> here?
During my testing of STP protocol, I found that Group 0 of reserved
multicast table needs to be updated. Since I have not worked on other
groups in the multicast table, I didn't update it.
I could not find the original patch to review, it shows "not found" in
lore.kernel.org.
Below are my comments,
- Why override bit is not set in REG_SW_ALU_VAL_B register.
- ksz9477_enable_stp_addr() can be renamed since it updates all the
table entries.
> Best Regards,
>
> Tim
next prev parent reply other threads:[~2025-01-16 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241212215132.3111392-1-tharvey@gateworks.com>
2024-12-13 0:00 ` [PATCH net] net: dsa: microchip: ksz9477: fix multicast filtering Vladimir Oltean
2024-12-13 0:32 ` Tim Harvey
2024-12-13 1:14 ` Vladimir Oltean
2024-12-27 19:06 ` Tim Harvey
2025-01-03 3:29 ` Arun.Ramadoss
2025-01-14 18:27 ` Tim Harvey
2025-01-16 9:06 ` Arun.Ramadoss [this message]
2025-01-17 1:09 ` Tristram.Ha
2025-01-17 1:25 ` Tim Harvey
2025-01-17 16:13 ` Vladimir Oltean
2025-01-17 21:02 ` Tim Harvey
2025-01-18 1:18 ` Vladimir Oltean
2025-01-23 1:48 ` Tim Harvey
2025-01-27 12:54 ` Vladimir Oltean
2025-01-18 0:49 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55858a5677f187e5847e7941d62f6f186f5d121c.camel@microchip.com \
--to=arun.ramadoss@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=tharvey@gateworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox