From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Abdelrhman Ahmed <ab@abahmed.com>, davem <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: Reset skb to network header in neigh_hh_output
Date: Fri, 7 Oct 2016 19:27:34 +0300 [thread overview]
Message-ID: <572cddd1-6a03-4c83-1e0e-55be37273396@cogentembedded.com> (raw)
In-Reply-To: <1579f7f0f4f.114457ec828613.4349884782265574217@abahmed.com>
Hello.
On 10/07/2016 05:14 PM, Abdelrhman Ahmed wrote:
> When hardware header is added without using cached one, neigh_resolve_output
> and neigh_connected_output reset skb to network header before adding it.
> When cached one is used, neigh_hh_output does not reset the skb to network
> header.
>
> The fix is to reset skb to network header before adding cached hardware header
> to keep the behavior consistent in all cases.
>
> Signed-off-by: Abdelrhman Ahmed <ab@abahmed.com>
> ---
> include/net/neighbour.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/neighbour.h b/include/net/neighbour.h
> index 8b68384..4d89fc2 100644
> --- a/include/net/neighbour.h
> +++ b/include/net/neighbour.h
> @@ -424,7 +424,7 @@ static inline struct neighbour * neigh_clone(struct neighbour *neigh)
> static inline int neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)
> {
> unsigned long now = jiffies;
> -
> +
Unraleted white-space change.
> if (neigh->used != now)
> neigh->used = now;
> if (!(neigh->nud_state&(NUD_CONNECTED|NUD_DELAY|NUD_PROBE)))
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-10-07 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 14:14 [PATCH] net: Reset skb to network header in neigh_hh_output Abdelrhman Ahmed
2016-10-07 16:27 ` Sergei Shtylyov [this message]
2016-10-07 16:38 ` Sergei Shtylyov
2016-10-07 21:10 ` Eric Dumazet
2016-10-25 23:57 ` Abdelrhman Ahmed
2016-10-26 0:12 ` Eric Dumazet
2016-10-26 16:53 ` Abdelrhman Ahmed
2016-10-26 17:08 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572cddd1-6a03-4c83-1e0e-55be37273396@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ab@abahmed.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox