From: Jacob Keller <jacob.e.keller@intel.com>
To: Fan Wu <fanwu01@zju.edu.cn>, <netdev@vger.kernel.org>
Cc: <przemyslaw.kitszel@intel.com>, <horms@kernel.org>,
<shenjian15@huawei.com>, <salil.mehta@huawei.com>,
<dingtianhong@huawei.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH net] net: hip04: fix RX buffer leak on build_skb failure
Date: Wed, 15 Jul 2026 09:52:18 -0700 [thread overview]
Message-ID: <59b22ed2-3b75-475d-a922-08bac1de6087@intel.com> (raw)
In-Reply-To: <20260712142729.2057636-1-fanwu01@zju.edu.cn>
On 7/12/2026 7:27 AM, Fan Wu wrote:
> When build_skb() fails in hip04_rx_poll(), the driver jumps to the
> refill path without releasing the current RX buffer and its DMA mapping.
> Installing a replacement buffer then overwrites the slot references and
> leaks both resources.
>
> Keep the current slot intact and return budget so NAPI retries the same
> buffer. Also free a newly allocated RX fragment when dma_map_single()
> fails.
>
> This issue was found by an in-house static analysis tool.
>
> Fixes: 701a0fd52318 ("hip04_eth: fix missing error handle for build_skb failed")
> Cc: stable@vger.kernel.org
> Assisted-by: Codex:gpt-5.5
> Signed-off-by: Fan Wu <fanwu01@zju.edu.cn>
> ---
>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
prev parent reply other threads:[~2026-07-15 16:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-12 14:27 [PATCH net] net: hip04: fix RX buffer leak on build_skb failure Fan Wu
2026-07-15 0:17 ` Jacob Keller
2026-07-15 7:30 ` Fan Wu
2026-07-15 16:51 ` Jacob Keller
2026-07-15 16:52 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b22ed2-3b75-475d-a922-08bac1de6087@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dingtianhong@huawei.com \
--cc=edumazet@google.com \
--cc=fanwu01@zju.edu.cn \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox