From: tanhuazhong <tanhuazhong@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linuxarm@huawei.com>
Subject: Re: [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed
Date: Thu, 2 Aug 2018 08:59:03 +0800 [thread overview]
Message-ID: <59f1d5b3-7d1d-e030-0629-8c125fee8f79@huawei.com> (raw)
In-Reply-To: <20180801.100332.1084702659051147259.davem@davemloft.net>
On 2018/8/2 1:03, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@huawei.com>
> Date: Wed, 1 Aug 2018 17:53:28 +0800
>
>> From: fredalu <fredalu@yeah.net>
>>
>> While cleaning the command queue, the value of the HEAD register is not
>> in the range of next_to_clean and next_to_use, meaning that this value
>> is invalid. This also means that there is a hardware error and the
>> hardware will trigger a reset soon. At this time we should return an
>> error code instead of 0, and HCLGE_STATE_CMD_DISABLE needs to be set to
>> prevent sending command again.
>>
>> Fixes: 3ff504908f95 ("net: hns3: fix a dead loop in hclge_cmd_csq_clean")
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>wq
> ---> ^^^
>
> I think I know what text editor you use... :-)
>
> Applied with 'wq' removed from your signoff... Thanks.
>
> .
>
Sorry about this, I have sent V2 to fix it.
Thanks.:)
prev parent reply other threads:[~2018-08-02 2:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 9:53 [Patch net-next] net: hns3: fix return value error while hclge_cmd_csq_clean failed Huazhong Tan
2018-08-01 10:00 ` 答复: " tanhuazhong
2018-08-01 17:03 ` David Miller
2018-08-02 0:59 ` tanhuazhong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59f1d5b3-7d1d-e030-0629-8c125fee8f79@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=linuxarm@huawei.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox