From: Qingfang Deng <qingfang.deng@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
bpf@vger.kernel.org, john.fastabend@gmail.com,
sd@queasysnail.net, linux-kselftest@vger.kernel.org,
stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH net 1/7] net: tls: fix silent data drop under pipe back-pressure
Date: Tue, 29 Sep 2026 14:18:06 +0800 [thread overview]
Message-ID: <5b0a6f1a-d44f-4e7d-9931-4106172d6258@linux.dev> (raw)
In-Reply-To: <20260429222944.2139041-2-kuba@kernel.org>
Hi Jakub,
On 2026/4/30 6:29, Jakub Kicinski wrote:
> tls_sw_splice_read() uses len when advancing rxm->offset / rxm->full_len
> after skb_splice_bits(), rather than copied (the actual number of bytes
> successfully spliced into the pipe). When the destination pipe cannot
> accept all the requested bytes, splice_to_pipe() returns fewer bytes
> than len, and 'len - copied' of data is effectively skipped over.
>
> Fixes: e062fe99cccd ("tls: splice_read: fix accessing pre-processed records")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: john.fastabend@gmail.com
> CC: sd@queasysnail.net
> ---
> net/tls/tls_sw.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
I just hit this bug on v6.18.y. Somehow this was not automatically
backported to stable?
+Cc: stable
Best regards,
Qingfang
next prev parent reply other threads:[~2026-09-29 6:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 22:29 [PATCH net 0/7] net: tls: fix a few random bugs Jakub Kicinski
2026-04-29 22:29 ` [PATCH net 1/7] net: tls: fix silent data drop under pipe back-pressure Jakub Kicinski
2026-09-29 6:18 ` Qingfang Deng [this message]
2026-09-29 18:50 ` Sasha Levin
2026-04-29 22:29 ` [PATCH net 2/7] selftests: tls: add test for data loss on small pipe Jakub Kicinski
2026-04-29 22:29 ` [PATCH net 3/7] net: tls: fix page pin leak on sendpage_ok() failure Jakub Kicinski
2026-04-29 22:29 ` [PATCH net 4/7] net: tls: fix off-by-one in sg_chain entry count for wrapped sk_msg ring Jakub Kicinski
2026-05-01 16:40 ` Sabrina Dubroca
2026-05-03 1:26 ` Jakub Kicinski
2026-04-29 22:29 ` [PATCH net 5/7] selftests: bpf: cover wrapped sk_msg ring chaining in ktls TX path Jakub Kicinski
2026-04-30 17:58 ` Jiayuan Chen
2026-04-29 22:29 ` [PATCH net 6/7] net: tls: fix use-after-free in tls_sw_sendmsg_locked after bpf verdict Jakub Kicinski
2026-04-30 17:50 ` Jiayuan Chen
2026-04-29 22:29 ` [PATCH net 7/7] selftests: bpf: cover tls_sw_sendmsg UAF after bpf_exec_tx_verdict split Jakub Kicinski
2026-04-30 17:55 ` Jiayuan Chen
2026-05-03 2:20 ` [PATCH net 0/7] net: tls: fix a few random bugs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b0a6f1a-d44f-4e7d-9931-4106172d6258@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=sd@queasysnail.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox