Re: [PATCH net] net: remove SIOCSHWTSTAMP and SIOCGHWTSTAMP from ndo_eth_ioctl comment

[Vadim Fedorenko <vadim.fedorenko@linux.dev>]

On 27/05/2026 13:09, Xuan Zhuo wrote:
> Since commit 4ee58e1e5680 ("net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP
> ioctls to dedicated handlers"), SIOCSHWTSTAMP and SIOCGHWTSTAMP are no
> longer dispatched through dev_eth_ioctl() / ndo_eth_ioctl(). They are
> now handled by their own dedicated functions dev_set_hwtstamp() and
> dev_get_hwtstamp() in the ioctl path.
> 
> However, the comment describing ndo_eth_ioctl in netdevice.h still
> lists these two ioctls, which is misleading for driver developers who
> may incorrectly assume they need to handle hardware timestamping
> commands in their ndo_eth_ioctl implementation.
> 
> Remove the stale references from the comment to accurately reflect that
> ndo_eth_ioctl only handles SIOCGMIIPHY, SIOCGMIIREG and SIOCSMIIREG.
> 
> Fixes: 4ee58e1e5680 ("net: promote SIOCSHWTSTAMP and SIOCGHWTSTAMP ioctls to dedicated handlers")
> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> ---
>   include/linux/netdevice.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index bf3dd9b2c1a7..7309467d7873 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -1149,8 +1149,8 @@ struct netdev_net_notifier {
>    *	SIOCBONDSLAVEINFOQUERY, and SIOCBONDINFOQUERY
>    *
>    * * int (*ndo_eth_ioctl)(struct net_device *dev, struct ifreq *ifr, int cmd);
> - *	Called for ethernet specific ioctls: SIOCGMIIPHY, SIOCGMIIREG,
> - *	SIOCSMIIREG, SIOCSHWTSTAMP and SIOCGHWTSTAMP.
> + *	Called for ethernet specific ioctls: SIOCGMIIPHY, SIOCGMIIREG and
> + *	SIOCSMIIREG.
>    *
>    * int (*ndo_set_config)(struct net_device *dev, struct ifmap *map);
>    *	Used to set network devices bus interface parameters. This interface


Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>