Re: [PATCH] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi Luis,

On 7/18/26 17:27, Luis Lang wrote:
> Since commit 1b9707e6f1a9 ("net: stmmac: enable RPS and RBU
> interrupts"), suspending causes an interrupt storm from the RPS
> interrupt.
> Fix this by adding a deinit_chan() op to stmmac_dma_ops, which
> masks all default dma channel interrupts. This is called from
> stmmac_stop_all_dma(), so interrupts don't trigger while suspending.
> 
> Fixes: 1b9707e6f1a9 ("net: stmmac: enable RPS and RBU interrupts")
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Suggested-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> Signed-off-by: Luis Lang <luis.la@mail.de>

This is almost perfect for a new submission, only 2 things to improve :

 - you're missing the tree name in the patch subject. As this is a fix, it should be :

   [PATCH net] net: stmmac: dwmac4: mask interrupts before stopping DMA in suspend

   you can find instructions for this in the doc Andrew linked :

   https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

 - When submitting a patch, do so in a dedicated thread, and not in reply to
   other threads.

You should send a V2 addressing the tree name in the patch subject.

Sashiko noted something on the patch :

  https://sashiko.dev/#/patchset/20260718152802.83553-1-luis.la%40mail.de

It looks to me that sashiko is just wrong there though, I can't make sense
of what it is saying.

Maxime